fix(retrieval): use token hashes for map-unit frequency lookup - #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production classic retrieval still queried
document_map_unit_tokens.tokenwithANY(...), bypassing the existing(channel, token_hash, map_unit_id)index. The affected production request hit PostgreSQL statement timeout after about 42 seconds.This change hashes the same normalized query tokens with SHA-256 and uses
token_hash = ANY(...)for the frequency lookup. The response still selects the original token and frequency, so scoring behavior is unchanged; only the lookup predicate changes.Validation
uv run pytest apps/api/tests/contract/test_retrieval_classic_map_unit_contract.py(3 passed)uv run ruff check packages/shared-python/shared/services/retrieval/search/map_unit_discovery.py apps/api/tests/contract/test_retrieval_classic_map_unit_contract.pyuv run pyright packages/shared-python/shared/services/retrieval/search/map_unit_discovery.py apps/api/tests/contract/test_retrieval_classic_map_unit_contract.pygit diff --checkDeployment follow-up
After deployment, rerun the production classic request and verify HTTP 200, no
statement timeout, and a Logfire SQL span containingtoken_hash = ANY(...)rather thantoken = ANY(...). No backfill rerun is required for this code-only lookup change.