refactor(retrieval): plan query-only then light from retrieval_query - #375
Merged
Conversation
…y query logic This commit removes the `n_chunks` attribute from various classes and functions related to navigation and retrieval, streamlining the codebase. Additionally, it updates the frequency query logic to drive lookups from `document_map_unit_tokens`, enhancing performance and clarity in the retrieval process. Tests have been adjusted to reflect these changes.
Defer corpus map scoring until after the planner emits subgoals, cache those scores for harvest, and keep refine map-aware after lighting. Co-authored-by: Cursor <cursoragent@cursor.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| prepared_relights[query] = prepared | ||
| if scores: | ||
| state.relit_map_cache[query] = prepared | ||
| except Exception: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retrieval_querystrings (baseline + cache).n_chunkspath and tighten persisted frequency lookup.Test plan
make checktest_nav_plan_query_only, plan/node-filter/trace/wire, mapnav session contract)map_scoringonly after planner; no second full-corpus score on first waveMade with Cursor