Fix includes so that include sorting in clangformat doesn't break anything - #748
Merged
Merged
Conversation
mcarans
requested review from
AnotherCommander,
Kaks,
KonstantinosSykas,
dsalt,
ericwalch,
jobi-wan,
kanthoney,
mwerle,
oocube and
phkb
as code owners
September 21, 2026 00:30
mcarans
force-pushed
the
fix_includes
branch
from
September 23, 2026 22:31
1ae63be to
0b5bce9
Compare
Contributor
Author
|
@phkb Does this work for you? |
phkb
approved these changes
Sep 23, 2026
Contributor
|
All good from me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#pragma oncewith correct include hierarchy to avoid multiple inclusion of same headers instead ofINCLUDED_OOMATHS_hdefine workaroundIn my testing with this fix, Oolite compiled and ran successfully before and after running clang-format. Without it, there are compile errors after clang-format due to things not being included correctly.