Repository navigation
fix(dev): prepare missing Harness runtime before startup - #288
Merged
Merged
Conversation
hm1229
marked this pull request as ready for review
October 22, 2026 03:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a source upgrade,
scripts/dev_up.sh --detachcould restart the application without building the newly required Harness v3 engine, resulting inapps/cli/lib/bin.js missing. The shared development CLI now checks the bundled engine entry point, dependencies and Python SDK, then runs OSS preparation and installs the local SDK into the active environment when needed. Once prepared, later starts skip rebuilding the engine.Preparation uses the reviewed bundled Node and the project's pinned pnpm through npm's cache, so users do not need to globally install pnpm or enable Corepack. Both preparation entrypoints stay identical. The PowerShell wrapper prefers the existing backend virtualenv so SDK installation and the supervised backend use the same environment.
Runtime preparation and normal frontend builds complete before existing services are stopped. A preparation error exits with the original supervisor and service still running. The existing external engine override is preserved. Startup errors and installation/upgrade docs also explain recovery for directly managed launch.py/uvicorn services.
Validation:
dev_up.sh --detach: host/client builds and local SDK installation completed automatically, service startup/route readiness passed, and the saved credential and employee survived the restart.dev_up.sh --detachagain: engine entry timestamp was unchanged, no runtime preparation was triggered, and the credential/employee remained valid. The owned supervisor was then stopped; the user's separate local instance remained healthy.The first missing-runtime repair downloads dependencies and builds in the source tree; subsequent complete-runtime starts reuse those outputs. This change does not publish a new release tag.