Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows machines where the system MIME database maps
.jstotext/plain, browsers reject the frontend module and the page stays blank. The multi-dist asset handler inherited directly fromStaticFiles, bypassing the existing MIME correction inFrontendStaticFiles.Make
MultiDistStaticFilesinherit fromFrontendStaticFilesto restore that correction while preserving its directory lookup and path checks. Update the regression test to exercise the registered handlers for/assets,/enterprise/assets,/chat/assets,/workspace/assets, and/admin/assets, using GET and HEAD with an asset present only in the fallback build directory.Validation:
PYTHONPATH=backend:backend/src DATABASE_URL=sqlite:///:memory: ULTRARAG_DATA_DIR=<temporary-directory> python -m pytest backend/tests/test_single_port_app.py -q: 20 passed, with real application imports and no application stubs.text/plain.git diff --checkpasses. Ruff reports the same seven pre-existing I001/RUF100 diagnostics before and after this change.