SYLVANIA RGBW Color Filament bulbs: fix SM2135_Current - #299
Draft
ryan-ronnander wants to merge 1 commit into
Draft
ryan-ronnander wants to merge 1 commit into
ryan-ronnander wants to merge 1 commit into
Conversation
- SM2135_Current takes register codes rather than mA, and OpenBeken packs its first argument into the nibble the chip reads for the white group, so stock's 20 mA RGB and 40 mA white is `6 2` - `20 40` ran all three bulbs about 20% below stock brightness; `6 2` matches the stock power readings
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a mistake translating the stock Tuya LED currents to OpenBeken in #295.
SM2135_Currenttakes register codes rather than mA, and its first argument lands on the white group, so stock's 20 mA RGB / 40 mA white isSM2135_Current 6 2, not20 40.Measured on the A19 behind a Sonoff S31, full brightness:
20 40(current)6 2(this PR)I've gone back and edited the JSON in the original forum post to match.
Marking this as a draft: openshwprojects/OpenBK7231T_App#2243 adds
led_colorBlendLimitfor color mode power on these bulbs, and I'd like to add it to these entries in the same PR once it's released.