feat: add timeout to SMD token refresh and benchmark - #130
Open
synackd wants to merge 3 commits into
Open
Conversation
synackd
force-pushed
the
pr/b-token-refresh-timeout
branch
2 times, most recently
from
August 31, 2026 16:28
3360725 to
ba43b84
Compare
Introduce a 10‑second timeout for SMD token refresh operations to prevent potential deadlocks when the OIDC token endpoint is slow or unresponsive. A new constant defaultRefreshTimeout is defined and used with context.WithTimeout in both RefreshToken and refreshTokenIfCurrent. A refreshLock mutex is added to serialize concurrent refresh attempts, ensuring only one refresh request proceeds at a time. Additionally, a benchmark BenchmarkRefreshToken (in smdclient_benchmark_test.go) measures the latency of the refresh path. Comprehensive tests have been added to verify correct behavior under concurrent requests. These changes improve robustness of the SMD client during token expiration handling. Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
synackd
force-pushed
the
pr/b-token-refresh-timeout
branch
from
August 31, 2026 16:31
ba43b84 to
206a36f
Compare
15 tasks
synackd
marked this pull request as ready for review
August 31, 2026 16:44
17 tasks
alexlovelltroy
requested changes
Aug 31, 2026
| if err != nil { | ||
| return err | ||
| } | ||
| r, err := http.DefaultClient.Do(req) |
Member
There was a problem hiding this comment.
shouldn't this be s.smdClient rather than http.DefaultClient to benefit from our custom configs?
Contributor
Author
There was a problem hiding this comment.
Not sure how I missed that... Fixed in 0a95d36. Added nil-check for the client, let me know if the error message should be revised.
| defer s.accessTokenMutex.Unlock() | ||
| return s.refreshTokenLocked() | ||
| // Serialize refresh to avoid concurrent token fetches. | ||
| s.refreshLock.Lock() |
Member
There was a problem hiding this comment.
I think s.refreshLock doesn't exist in this branch.
Contributor
Author
There was a problem hiding this comment.
Whoops, somehow did not get committed (fe17047). I also somehow missed running go build to catch that...
| if err != nil { | ||
| return err | ||
| } | ||
| r, err := http.DefaultClient.Do(req) |
Member
There was a problem hiding this comment.
s.SMDClient has a built-in http client that is optimized for SMD queries. It is probably better here.
Contributor
Author
There was a problem hiding this comment.
Dumb error on my part... Addressed in 0a95d36.
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a 10‑second timeout for SMD token refresh operations to prevent potential deadlocks when the OIDC token endpoint is slow or unresponsive. A new constant
defaultRefreshTimeoutis defined and used withcontext.WithTimeoutin bothRefreshTokenandrefreshTokenIfCurrent. ArefreshLockmutex is added to serialize concurrent refresh attempts, ensuring only one refresh request proceeds at a time. Additionally, a benchmarkBenchmarkRefreshToken(insmdclient_benchmark_test.go) measures the latency of the refresh path. Comprehensive tests have been added to verify correct behavior under concurrent requests. These changes improve robustness of the SMD client during token expiration handling.Fixes #128 (comment)
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change