Skip to content

Restore automatic/manual region selection and show the streaming server - #25

Merged
Portablelle merged 2 commits into
codex/fix-login-session-recoveryfrom
codex/restore-region-selection
Nov 1, 2026
Merged

Portablelle merged 2 commits into
codex/fix-login-session-recoveryfrom
codex/restore-region-selection

Conversation

@Portablelle

Copy link
Copy Markdown
Collaborator

Settings > Network restores Automatic (NVIDIA) routing and a saved manual region selected from NVIDIA's current list. The UI shows the regional endpoint separately from the allocated streaming server, including while connecting and in the keyboard/mouse overlay.

V1–V4 settings migrate to Automatic. The preference applies to new allocations and game home-screen tiles. Catalog access and recovery of existing sessions remain independent of an unavailable manual allocation region. Refreshing regions preserves catalog and launch state. No region latency ranking or measured latency improvement is claimed.

Depends on #24. This PR targets its branch to show only the region changes. Merge #24 first, then retarget this PR to main before merging.

Validation: settings migration/persistence, cloud routing/recovery and catalog isolation, controller UI, and forwarded-launch worker regressions under ASan/UBSan; Network-pane previews visually checked. Worker tests were rerun after rebasing onto the final #24 changes. Cubic review passed. PS5 hardware validation remains outstanding.

Refs #23. Reintroduces the region changes removed from main by d08c1a0.

Persist automatic or manual region preferences, expose Network settings, and show the allocated media server. Keep catalog access and session recovery independent of allocation-region availability. Add migration, cloud routing, controller, and forwarded-launch regressions. Refs #23.
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4e9b4a3b-bb7e-4125-8457-d71040688328
Commits

Reviewing files that changed from the base of the PR and between 8a49615 and 3c7ad26.

Files selected for processing: 15
  • README.md
  • docs/DEVELOPMENT_BUILDS.md
  • src/cloud.cpp
  • src/cloud.hpp
  • src/main.cpp
  • src/region.hpp
  • src/settings_file.hpp
  • src/ui/stream_store.hpp
  • src/ui/tv_ui.cpp
  • src/ui/tv_ui.hpp
  • tests/cloud_test.cpp
  • tests/forward_launch_worker_test.cpp
  • tests/main_ui_test.cpp
  • tests/settings_file_test.cpp
  • tools/preview-port.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T15:22:16.402555Z 9542920 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Portablelle
Portablelle merged commit ae770bc into codex/fix-login-session-recovery Nov 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant