Repository navigation
Accept NVIDIA region names and show session recovery progress - #31
Open
ducktailgoat wants to merge 2 commits into
Open
ducktailgoat wants to merge 2 commits into
ducktailgoat wants to merge 2 commits into
Conversation
serverInfo keys regions by display name ("France 1", "United Kingdom 2",
"Northern California (USA)"), but validRegionName only allowed
[A-Za-z0-9_-]. 18 of the 24 current regions, including the usual local
region, were rejected, which marks region discovery incomplete. Session
recovery then fails with "Could not check every cloud region" whenever
no existing session is found, so every launch after a saved session
profile fails and retrying cannot succeed. Manual region selection also
only offered single-word regions.
Allow spaces and parentheses. URL and path characters stay rejected, so
"https://..." and "../west" are still refused as region names and
settings records.
With every region accepted, recovery checks all 24 regions plus the global endpoint sequentially. On a PS5 in France that took about 8.4 s, against a 9 s budget, so a slower connection would again fail with "Could not check every cloud region" when no session exists. Raise the budget to 20 s. Recovery triggered by Play or Try again also blocked without publishing any state, so the UI fell back to the game list for those seconds before the connecting screen appeared. Publish the starting state with a "Checking for an existing cloud session..." message first, as the normal launch path already does. The silent check at catalog load is unchanged.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serverInfokeys regions by display name ("France 1", "United Kingdom 2", "Northern California (USA)"), butvalidRegionNameonly allowed[A-Za-z0-9_-]. 18 of the 24 current regions were rejected, including the usual local region, and each rejection marks region discovery incomplete. With a saved session profile and no live session, every launch then fails with "Could not check every cloud region. Retry session recovery before launching", and retrying can never succeed. Manual region selection also only offered single-word regions.The last change fixes a UI glitch the longer check made visible: Play went back to the game list for the whole check, then jumped to the connecting screen. The normal launch path already publishes the starting state first; the silent check at catalog load is unchanged.
Evidence
Measured on a PS5 in France with temporary per-region logging (not part of this PR):
tests/cloud_test.cppcase recovers with NVIDIA-style names and assertsRecoveryResult::none, all three regions listed, and selectable names. It failed before and passes after. URL and path names are still rejected.tests/settings_file_test.cpptreated"EU WEST"as corrupt, which contradicts NVIDIA's data: NVIDIA-style names now round-trip, and a tab-separated name is the whitespace rejection case. The rest oftools/test-port.shgives the same results asmain.serverInforeturns the same 24 regions with the native and browser client identities, so this is independent of Request WebRTC rigs with the CloudMatch browser identity #28. The console builds also contained Request WebRTC rigs with the CloudMatch browser identity #28, Let FTP read diagnostics logs in the storage root #29 and Backport OpenNOW-Switch #49 signaling and allocation hardening #30.Merge Danger
Door: mostly two-way. One way: a settings file saved with a region such as "France 1" is rejected as corrupt by older builds, which then reset stream settings to defaults.
Blast Radius: session recovery and region selection.
Recovery can now block for up to 20 s instead of 9 s, behind a progress screen. Each region's
/v2/sessionreturned the same account-wide list (sessions=1from all 25 endpoints), so checking only the global endpoint would take about 0.1 s. I left the check-every-region design unchanged; your call.