Skip to content

Make an UpdateGoldenValues.jl script #228

Description

@d-burg

After creating a GoldenValues .h5 file that goes in test data, we need to make a script that will selectively update this .h5 with new data. This should require user input of the desired quantity to update and take the current commit hash, printing a warning if there are any unstaged changes.

Activity

  1. added theissue type on Jun 11, 2026
  2. logan-nc commented on Jun 11, 2026

    @logan-nc
    Collaborator

    @d-burg @matt-pharr can this be closed now that we have the regression harness set up?

  3. matt-pharr commented on Jun 12, 2026

    @matt-pharr
    Collaborator

    @logan-nc no, the regression harness is made mostly for local use. This is part of a bigger effort we discussed on refactoring the unit test infrastructure. There is a fair amount of benchmarking that needs to happen first and we want to get a few things merged before we do that.

  4. added this to the GPEC v2.0.0 milestone on Jun 17, 2026
  5. logan-nc commented on Oct 27, 2026

    @logan-nc
    Collaborator

    Not opening a PR: there is no golden .h5 under test/test_data on develop (the regression_* directories hold only gpec.toml decks), so a script to update one has nothing to act on, and the unit tests pin values inline. The role described here is what regression-harness/ plays today, and #593 is reshaping the unit-test side. Suggest deciding there whether a golden file is still wanted; if not, close in favour of the harness.

  6. removed this from the GPEC v2.0.0 milestone on Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

testTests only

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions