You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After creating a GoldenValues .h5 file that goes in test data, we need to make a script that will selectively update this .h5 with new data. This should require user input of the desired quantity to update and take the current commit hash, printing a warning if there are any unstaged changes.
@logan-nc no, the regression harness is made mostly for local use. This is part of a bigger effort we discussed on refactoring the unit test infrastructure. There is a fair amount of benchmarking that needs to happen first and we want to get a few things merged before we do that.
Not opening a PR: there is no golden .h5 under test/test_data on develop (the regression_* directories hold only gpec.toml decks), so a script to update one has nothing to act on, and the unit tests pin values inline. The role described here is what regression-harness/ plays today, and #593 is reshaping the unit-test side. Suggest deciding there whether a golden file is still wanted; if not, close in favour of the harness.
Activity
logan-nc commentedon Jun 11, 2026
@d-burg @matt-pharr can this be closed now that we have the regression harness set up?
matt-pharr commentedon Jun 12, 2026
@logan-nc no, the regression harness is made mostly for local use. This is part of a bigger effort we discussed on refactoring the unit test infrastructure. There is a fair amount of benchmarking that needs to happen first and we want to get a few things merged before we do that.
logan-nc commentedon Oct 27, 2026
Not opening a PR: there is no golden
.h5undertest/test_dataon develop (theregression_*directories hold onlygpec.tomldecks), so a script to update one has nothing to act on, and the unit tests pin values inline. The role described here is whatregression-harness/plays today, and #593 is reshaping the unit-test side. Suggest deciding there whether a golden file is still wanted; if not, close in favour of the harness.