Skip to content

Ground-up overhaul needed to conform all fundemental matrices to a single, coordinate invariant convention #233

Open
1 of 1 issue completed

Description

@logan-nc

PR #225 starts this by converting the coordinate dependent energy eigenvalues/modes of DCON to coordinate-independent eigenvectors with eigenvalues of energy per power-normalized-flux.

All fundamental matrices should be consistently formed in the same space. This includes, for example, the Permeability and reluctance matrices of PerturbedEquilibria. Of course, the resonant coupling matrices should be as well. Some thought should be put into the left hand side normalizations of resonant coupling matrices (flux is explicitly ok by [Park 2008], but check the others - shielding current, delta', penetrated field/flux, etc. - and add annotations confirming they are all also ok).

When implemented, the torque response matrix should be similarly normalized.

Lets make the code operate, as much as possible, directly in this consistently defined space.

The exception, for now, is the ForceFreeStates Euler-Lagrange integration done in displacement-space. After everything else in in a power-norm-flux space, we can close this issue and open a new you if we want/plan to attempt converting that to operate directly in the power-norm-flux space. The expectation is that the (m-nq) factors converting from displacement to flux will improve large solution numerics near rationals but possibly result in lossy suppression of the small solutions.

This should go on the back-burner lists for @ebursch and @matt-pharr - good weekend task for vibe coding

Activity

  1. added
    featureNew capability
    help wantedExtra attention is needed
    refactorBehavior-preserving restructuring
    on Apr 29, 2026
  2. added theissue type on Apr 29, 2026
  3. added this to the GPEC v2.0.0 milestone on Jun 17, 2026
  4. added a commit that references this issue on Jun 21, 2026
  5. logan-nc commented on Oct 27, 2026

    @logan-nc
    CollaboratorAuthor

    Status rather than a PR: #225 moved the eigenvalues to the power-norm flux space, #237's scan verified the five resonant-coupling matrices are coordinate-independent, and #472 added the torque response matrices. What remains is the audit of the PerturbedEquilibrium matrices (permeability, reluctance, torque response) against one normalisation and the annotations confirming each, which is a design pass across the module rather than a bug fix. The natural moment is right after #574, which moves all of those matrices onto pe.response, so there is one place to audit.

  6. logan-nc commented on Oct 30, 2026

    @logan-nc
    CollaboratorAuthor

    @matt-pharr how about moving this to v2.1 or later?
    I still like the dream, but it seems like rushing it right now could lead to bugs and I don't think I'd hold the release just for this.

  7. removed this from the GPEC v2.0.0 milestone on Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

featureNew capabilityhelp wantedExtra attention is neededrefactorBehavior-preserving restructuring

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions