Repository navigation
Declare bundle-only Fiji cache and download-forbidden admission (#224) - #17
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
September 29, 2026 21:37
This was referenced Sep 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical cache checkpoint
Refs OpenHCSDev/openhcs#224 and OpenHCSDev/openhcs#206; extracted at the owner's explicit request from #16. This is the same implementation on recorded/current PolyStore main
f94bbbe, not a competing runtime or compatibility path. Original Java-lifecycle and ROI work stays in16. Parent will pin this exact commit and owns review/merge/install.Paired parent: OpenHCSDev/openhcs#228 at
bf9aae4620585e98d10e469037ef98237884b4f8; its committed gitlink is this exact headc16b8fc99a07f17e92e5fbf46f312d73cc9c46d7.Existing
FijiArchiveDistributionownsPOLYSTORE_IMAGEJ_CACHE_ROOTand decodes it once into the canonical distribution's constructor. Use the existing bundle parent/home/ts/.cache/polystore/imagej, not its hashed Fiji subdirectory. Unset preserves platformdirs behavior; invalid explicit roots fail. Separate XDG logs/caches stay separate; release/digest/overlay, archive verification and atomic materialization remain canonical.Existing
ImageJArchiveDownloadPolicyownsPOLYSTORE_IMAGEJ_ALLOW_DOWNLOAD=true|false(unset retains its existing defaults). False rejects absent/invalid bundles before cache creation, lock/staging/removal or network, and rejects archive/overlay downloads before retries or temporary files. It still admits a valid existing bundle. No caller subclass/monkeypatch, symlink or shared-full-cache workaround required.Actual evidence
scripts/verify_existing_imagej_bundle.py.Focused architecture review
BOUND-1/2/6: external environment decoding belongs on the existing distribution/download-policy owners, not each consumer; canonical FIJI declaration projects constructor values once. MEMB-2/3: parent launch derives both key spellings from these owners; no duplicate default/filename/runtime registry. IMPL-12/13: extend the existing materializer/policy and parent progress binding, not a second cache or cold-start runner. New cache root requires one owner input, no BioFormats/viewer consumer edits; new download permission is decoded/enforced on the policy, not callers. Strict two-value environment decoding is boundary validation, not a missing runtime family. Scope is changed-source/catalog and behavioral checks, not a full NRA/native/global proof.
Remaining gates
Real installed stdio MCP inspection + concurrent discovery and heartbeat during actual Java preparation remains parent-owned and resource-gated. No claim of installed readiness or closure. Original16/206 combined result 141 passed/26 failed remains unresolved there; after-ROI profile did not run. Those preparation/ROI changes are not in this small checkpoint. Original uncertain science receipts/foreign handles untouched. No merge/install by this worker.