Repository navigation
fix: carry producer-owned ACK return routes through streaming batches - #19
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
September 30, 2026 20:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACK-specific consumer of OpenHCSDev/ZMQRuntime#12, paired with OpenHCSDev/openhcs#297. FINAL source head dc34173. Starts the real listener before allocation; carries typed route/image/producer through image and ROI builders. Both obsolete ACK calls in the historical Fiji ROI handler are migrated; environment fallback derives from ZMQConfig. PolyStore 0.3.0 / ZMQRuntime >=0.3.0,<0.4 cutover was already committed before parent took installed acceptance; no later package/pin edits. 36 focused checks pass, including all-source deleted-alias guard. Actual save/REP/shared-memory/deferred ACK TCP+IPC journey passes in OpenHCS. Original installed ratchet passes 265 metrics with no positive deltas. IMPORTANT retained limit: historical handlers import fails before our changes because metaclass_registry.lazy is absent; actual failed import is retained in PR12 docs/validation/issue10_polystore_handler_import_failure.txt/xml. Current OpenHCS viewer path does not import that package; its live readiness is not claimed. Parent integration owner adjudicates removal/current-owner migration if needed. No mocked import, compatibility shim or package install hides this failure. Final receipt/cleanup is in native PR12 ACK-RETURN-ROUTE-DELIVERY-20260930.rst. Worker source is frozen after handoff; parent alone owns normal current-main integration, paired activation and serialized installed acceptance.