Repository navigation
Delete the flat viewer placement-mode enum (0.5.0) - #27
Merged
Merged
Conversation
ViewerComponentMode mixed napari (stack, layer) and Fiji (window, channel, slice, frame) placement slots in one roster, restated by both OpenHCS viewer configs. Each viewer now owns its slot family (OpenHCS G6); the display payload carries modes as wire strings. ViewerComponentModeGroups, viewer_component_mode_value and ViewerBatchDisplayPayload.components_for_mode / component_mode_groups go with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
trissim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lockstep with OpenHCS G6 (domain-blind viewers).
ViewerComponentModemixed napari (stack, layer) and Fiji (window, channel, slice, frame) placement slots in one roster that both OpenHCS viewer configs restated. Each viewer now owns its slot family in OpenHCS; the display payload carries modes as wire strings. Deleted:ViewerComponentMode,ViewerComponentModeGroups,viewer_component_mode_value,ViewerBatchDisplayPayload.components_for_modeandcomponent_mode_groups.Version bumped to 0.5.0 (breaking: public names removed). Not tagged; do not merge before the OpenHCS G6 PR.
Tests (run from the OpenHCS worktree with the worktree's libraries on PYTHONPATH): 364 passed, 4 failed. The same 4 tests (
test_ack_return_route.pyx2,test_progress_annotation.pyx2) fail identically on the unmodified submodule commit.🤖 Generated with Claude Code