Skip to content

P253: delete commander overload refusal and FORK NOW - #1972

Merged
trissim merged 4 commits into
mainfrom
fix/p248-backlog-slice
Oct 19, 2026
Merged

trissim merged 4 commits into
mainfrom
fix/p248-backlog-slice

Conversation

@trissim

@trissim trissim commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

P253: delete the commander overload gate

This supersedes P248's judging-slice policy. Pushed cad44fe597998e16b87ac4a4921e54f88f3816f6 on the existing branch; #1972 was merged by the integration owner during verification. It is included in installed main 6a0f5e931. I did not merge, build, install or restart it.

Ownership and deletion

  • Restored main's Load.total: owed + 2 * overdue + unjudged / 10.
  • Deleted Load.require, short, needed, the per-commander threshold and the slice weighting.
  • Deleted LoadedVerb. Its four consumers inherit RuledVerb directly; eligibility and rule-review gates remain.
  • Deleted the ForkNow standing rule and its tests; kept Unjudged assertions.
  • Capacity reports numeric load/live forks, with no warning or refusal.

The existing AST/source census and semantic consumer read identified Load, the order verbs and ForkNow; all capacity-refusal consumers were removed. No new scanner, alternate policy or compatibility owner. Original change against its main: five files, 27 additions / 78 deletions; git diff --check clean. Current origin/main has zero def require matches in capacity.py (git grep returns 1 for no matches).

Actual CLI and tests

Real commander CLI and retained Core state, isolated scratch bus; no fake tools, provider call or production order:

capacity rc=0
load 36 (12 open orders, 12 overdue, 0 unjudged edits), 0 live forks []
order send ... --clean --mechanical --replaces ba467dd295ec: rc=0
New durable order: scratch-0 -> 3e9eecfdfe55
rules review: rc=0, no FORK NOW
rotate: emitted its normal ROTATE line and ordinary unrelated standing rules, no FORK NOW

Rotate was bounded with timeout 20 and unbuffered output, then stopped with expected rc=124 during its normal loop. The configured fleet's read-only capacity command also succeeded:

load 140 (39 open orders, 18 overdue, 646 unjudged edits), 1 live forks ['cmdr-core']

Separate source/tools ratchets on the pushed head using the existing shared .venv Python: src rc=0; tools rc=0; no positive deltas or introduced forbidden sites. Stack Python on that older source head lacks refactor_audit; it failed before checking anything. No environment install or source checker repair was made for this task.

Focused capacity/standing tests: 16 passed, 4 failed. All four failures are the existing board-progress cases requiring absent /home/ts/wt/worker--P109; the same four fail with main source. This is not a clean suite claim. Pytest's missing timeout-plugin warning is bounded by the external timeout and faulthandler.

Concise receipts under /home/ts/.cache/agent-scratch/pi-toad-list/: P253-src.json, P253-tools.json, P253-live-final.log, P253-rotate-visible.log, P253-capacity-live.log, P253-tests.log, P253-main-baseline.log.

Assumed

  • No new PR is opened for an already merged branch; this updates P253: delete commander overload refusal and FORK NOW #1972 in place with the current Core order identity.
  • A finite overloaded real CLI run confirms the path; deletion of the gate, not extrapolation from that one number, removes the threshold for every load.
  • These are source-head and actual scratch-CLI checks. The later install was performed by the integration owner, not this worker; I do not claim a separate post-install production order-send test.
  • Both merged development checkouts were removed in creation order after clean source/submodule and active-borrower checks. Receipts remain in persistent scratch. No provider, venv, build, recording or production state was created for P253.
  • After installation of main b793c73, the actual installed commander capacity entrypoint passed: load 207 (38 open orders, 34 overdue, 1008 unjudged edits), 0 live forks []. Receipt: P253-installed-b793-capacity.log.
  • Core still lists P253 pending. Delivery recording requires the commander, so no unit-side attempt or authority bypass was made for P253.

Agent-Comms-Order: 32eb31b928c4

Copilot AI balanced review requested due to automatic review settings October 19, 2026 19:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim marked this pull request as draft October 19, 2026 19:31
@trissim
trissim marked this pull request as ready for review October 19, 2026 19:33
@trissim trissim mentioned this pull request Oct 19, 2026
@trissim
trissim merged commit c3fd45b into main Oct 19, 2026
1 of 5 checks passed
@trissim trissim changed the title P248: count the unjudged backlog as one judging slice P253: delete commander overload refusal and FORK NOW Oct 19, 2026
@trissim
trissim deleted the fix/p248-backlog-slice branch October 20, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants