Repository navigation
Keep overdue reporting alive when a check prints no integer - #1987
Merged
Merged
Conversation
Keep check validation strict while distance observations retain the original count state. A missing latest count names its check instead of aborting the fleet report. Src-Budget: 64
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
…verdue # Conflicts: # src/agent_comms/todos.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P259 delivered at 1a04499. First source commit de1a682 was pushed at 16:39 EDT, before the requested 17:05 checkpoint. PR merged by the commander as ac71043 at 17:04:55 EDT; I did not install it.
Owner repair
CheckPrintedcarries either CountPrinted or NoIntegerPrinted through distance calculation and addition. NoIntegerPrinted.distance returns its original state, never a number or exception. Completion validation separately asks the state to require proof, and still refuses missing counts. CountCheckResult and SilentCheckResult both return this owned state; no caller expects distance() to throw.DistanceReading retains the original command beside its measured/missing state. DistanceReadings projects arithmetic trends only from counted readings. UncountedTrend (
src/agent_comms/todos.py:328) printscheck prints no integer: <command>beside the overdue formatter's existing order identity. No try/except was added around overdue, no zero fallback or result isinstance was added.Source-first refactor-audit Package before/after covered 381 production modules, zero parse omissions. Census covers declarations/inheritance and every distance/printed_count consumer; dynamic callback dispatch is source evidence, not behavioral proof. Artifacts: P259-ast-before.txt and P259-ast-after.txt under the sole scratch root. The only remaining
printed no integerraise is explicit proof refusal in NoIntegerPrinted.require, not distance or a catch dependent on distance throwing.Recorded exact check:
Raises 1 -> 0 for that check; missing-count distance itself also has zero raises.
Actual commander CLI
Ran the real
agent-comms-commander order overdueentrypoint with this source and two retained canonical orders copied to an isolated bus. Existing pi-toad-flash P259/P226 checkouts were used; no new checkout, provider input, fake process, live order mutation or UNKNOWN replay. Explicit safe reproducer checks were executed and their real outputs recorded before the progress read. The CLI was terminated after its first complete OVERDUE line.2026-10-19 16:57 EDT:
Both order IDs printed, missing integer explicit, no traceback. This is isolated retained-order CLI verification, not an installation claim. Command/output:
/home/ts/.cache/agent-scratch/pi-toad-flash/P259_cli.py,P259-cli/output.txt,P259-cli.log.Final checks
At final head 1a04499:
P259-final-src.json).P259-final-tools.json).test_unread_github_is_explicitdeselected, one missing pytest-timeout plugin warning. Shared agent-comms interpreter;PYTHONPATH=src; serial, no aggregate coverage gate for focused tests.P259-tests-final.log.git diff --checkclean.Initial run exposed the new regression fixture patching the wrong Comms instance; corrected it. It also reported pre-existing missing-checkout cases, resolved by the normal main integration, and the unrelated unread-GitHub failure. A later run lacked the pinned audit catalog; exported the exact existing local submodule object (no clone/fetch/install), then all selected tests passed. Raw failure logs are retained.
Source uses the existing documented Src-Budget trailer (64) to cover nominal count-state propagation; neither ratchet was modified or weakened. No persisted record-format change.
Coordination / assumptions
Storage: P219 was removed before P226; P259 is the second allowed active checkout because it is a different repository. Combined owned scratch and P226/P259 checkouts about 364 MB, below 3 GB; free disk above 5 GB. All source/checkouts remain under /home/ts/wt, all owned scratch under /home/ts/.cache/agent-scratch/pi-toad-flash. Earlier P226 remains retained for its unresolved physical-baseline-notification gap; do not remove P259 ahead of it contrary to creation-order rule.
Agent-Comms-Order: d35ec089b43f