Skip to content

Keep overdue reporting alive when a check prints no integer - #1987

Merged
trissim merged 5 commits into
mainfrom
fix/p259-no-integer-overdue
Oct 19, 2026
Merged

trissim merged 5 commits into
mainfrom
fix/p259-no-integer-overdue

Conversation

@trissim

@trissim trissim commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

P259 delivered at 1a04499. First source commit de1a682 was pushed at 16:39 EDT, before the requested 17:05 checkpoint. PR merged by the commander as ac71043 at 17:04:55 EDT; I did not install it.

Owner repair

CheckPrinted carries either CountPrinted or NoIntegerPrinted through distance calculation and addition. NoIntegerPrinted.distance returns its original state, never a number or exception. Completion validation separately asks the state to require proof, and still refuses missing counts. CountCheckResult and SilentCheckResult both return this owned state; no caller expects distance() to throw.

DistanceReading retains the original command beside its measured/missing state. DistanceReadings projects arithmetic trends only from counted readings. UncountedTrend (src/agent_comms/todos.py:328) prints check prints no integer: <command> beside the overdue formatter's existing order identity. No try/except was added around overdue, no zero fallback or result isinstance was added.

Source-first refactor-audit Package before/after covered 381 production modules, zero parse omissions. Census covers declarations/inheritance and every distance/printed_count consumer; dynamic callback dispatch is source evidence, not behavioral proof. Artifacts: P259-ast-before.txt and P259-ast-after.txt under the sole scratch root. The only remaining printed no integer raise is explicit proof refusal in NoIntegerPrinted.require, not distance or a catch dependent on distance throwing.

Recorded exact check:

grep -c 'raise ValueError(f"The order check printed no integer' src/agent_comms/child_process.py
0

Raises 1 -> 0 for that check; missing-count distance itself also has zero raises.

Actual commander CLI

Ran the real agent-comms-commander order overdue entrypoint with this source and two retained canonical orders copied to an isolated bus. Existing pi-toad-flash P259/P226 checkouts were used; no new checkout, provider input, fake process, live order mutation or UNKNOWN replay. Explicit safe reproducer checks were executed and their real outputs recorded before the progress read. The CLI was terminated after its first complete OVERDUE line.

2026-10-19 16:57 EDT:

OVERDUE: pi-toad-flash (due 16:56, order d35ec089b43f, PR #1987 open at 28960d3f4; check prints no integer: printf 'no count here'; no reply since the order), pi-toad-flash (due 16:56, order 51f143651953, merged as a0f57c3d1, awaiting record; no reply since the order) -> record merged work; push or merge unfinished work now

Both order IDs printed, missing integer explicit, no traceback. This is isolated retained-order CLI verification, not an installation claim. Command/output: /home/ts/.cache/agent-scratch/pi-toad-flash/P259_cli.py, P259-cli/output.txt, P259-cli.log.

Final checks

At final head 1a04499:

  • src ratchet rc=0 (P259-final-src.json).
  • tools ratchet rc=0 (P259-final-tools.json).
  • 137 tests passed, one pre-existing unrelated test_unread_github_is_explicit deselected, one missing pytest-timeout plugin warning. Shared agent-comms interpreter; PYTHONPATH=src; serial, no aggregate coverage gate for focused tests. P259-tests-final.log.
  • git diff --check clean.

Initial run exposed the new regression fixture patching the wrong Comms instance; corrected it. It also reported pre-existing missing-checkout cases, resolved by the normal main integration, and the unrelated unread-GitHub failure. A later run lacked the pinned audit catalog; exported the exact existing local submodule object (no clone/fetch/install), then all selected tests passed. Raw failure logs are retained.

Source uses the existing documented Src-Budget trailer (64) to cover nominal count-state propagation; neither ratchet was modified or weakened. No persisted record-format change.

Coordination / assumptions

  • Assumed: no integer is an unmeasured result, never distance zero; a latest broken reading must diagnose even with only one reading. If only the earlier reading is uncounted, no velocity is inferred.
  • Assumed: explicit delivery/proof validation must continue refusing the missing count, separately from nonthrowing observation.
  • P254's owner pi-cn-phase3 owns removal of check execution from read paths on P254: own PR integration states and finish record-plane checks #1935. Shared PresentCheckout/ProgressSource changes were coordinated directly; this PR preserves main's checkout capability family and does not implement a competing recorded-read path.
  • Newest P259 authorized distinct safe work while the persistent goal remained backend-blocked; no goal status was changed.

Storage: P219 was removed before P226; P259 is the second allowed active checkout because it is a different repository. Combined owned scratch and P226/P259 checkouts about 364 MB, below 3 GB; free disk above 5 GB. All source/checkouts remain under /home/ts/wt, all owned scratch under /home/ts/.cache/agent-scratch/pi-toad-flash. Earlier P226 remains retained for its unresolved physical-baseline-notification gap; do not remove P259 ahead of it contrary to creation-order rule.

Agent-Comms-Order: d35ec089b43f

Keep check validation strict while distance observations retain the original count state. A missing latest count names its check instead of aborting the fleet report.

Src-Budget: 64
Copilot AI balanced review requested due to automatic review settings October 19, 2026 20:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim merged commit ac71043 into main Oct 19, 2026
1 of 4 checks passed
@trissim
trissim deleted the fix/p259-no-integer-overdue branch October 20, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants