Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Contributor
Author
|
Closed as stale by desktop merger mB: it supervises and guards commander/rotate.py and the old tool_watch loops, but main has deleted rotate.py and replaced that rotation with the Core board (P707, #2100). Its loop guards have nothing left to guard on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P263: one commander monitor process
Loop owns thread lifetime, per-thread line framing, failure traceback output and restart on the next supervisor tick. OverdueLoop, RotateLoop and ToolWatchLoop own their original bodies in place; the individual CLI entrypoints call those same classes. InboxLoop reuses the original Claude bridge and its retained delivery journal rather than copying or replaying its input loop. Class declarations register through init_subclass.
The existing commander CLI discovers loops.py's main through pkgutil; no second handwritten tools roster was added at cli.py:19. The skill now names one command instead of five monitors.
Watch guard extension: the supervisor writes its declaration-derived loop names in LoopsRecord and holds a group claim. Each worker holds the existing kernel-backed WatchClaim for exactly its own running lifetime. Guard reads those original locks and names every missing registered loop; no heartbeat, boolean health mirror, process-restart counter or traceback suppression is introduced. The hook stays stdlib-only.
Verification is not yet complete. No runtime installed or active watcher stopped. A live-bus fault-injection run must preserve the existing inbox binding and UNKNOWN delivery journal; if the old watcher holds its claim, the new inbox must report that refusal rather than steal it.
Assumed: existing CLI module discovery is the requested tools registration; the original inbox bridge remains the authority for uncertain input attempts. The additional guard instruction is part of the same P263 implementation.
Agent-Comms-Order: 75c30907a54c