Repository navigation
P265: retain unparsed shell commands for hard-rule checks - #2005
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P265: malformed shell input remains visible to hard rules
First checkpoint: send_guard catches exactly the lexer ValueError and returns one UnparsedCommand with whitespace-separated words. ParsedCommand and UnparsedCommand preserve whether quoting was understood; hard-rule checks consume both instead of killing the watcher. No main-loop exception wrapper was added.
Timestamp producer/consumer migration is unfinished. Required float timestamps must be supplied before construction by each native/external record owner, not filled with a clock default after the event exists. Existing persisted NULL events require explicit source-backed disposition; this checkpoint does not drop them or claim the rotation failure fixed.
Live tool-watch and rotate acceptance are not yet claimed. No runtime installation changed.
Assumed: the explicit 120-second proof commands are the immediate verification requirement; they do not establish the separate 30-minute outcome.
Agent-Comms-Order: ad2701c3907f