Repository navigation
Conversation
Contributor
Author
|
Closing this draft under the new ready-only PR rule. The published branch fix/order-checkout-home and head 2964a0f remain intact. Real done acceptance passed for a non-Git home; an actual retained order checkout still refuses; 35 tests passed. Tools ratchet is 0, but src is 1 solely for net +10 source lines, so this is not ready for review. No source budget was self-granted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home storage is not an unreleased order checkout
Head:
2964a0fcb7e9b5a4d0270cacfd550df7ebe2d765. Reported by pi-toad-list, original message 3172; implementation owner pi-worker-cpu. No formal problem/order identity was invented.Production diff: 19 added / 9 removed (net +10).
StorageRule.checkouts_ofintentionally returns the home storage slot first, even when it is a non-Git directory; dropping that slot would change quota accounting. The completion gate incorrectly treated every returned path as a checkout and matched the problem by substring.The existing UnitStorage owner now derives
extra_checkoutsonce from that layout. Quota counting/reporting, checkout removal and completion consume this distinction. Quota validation moved into UnitStorage so done reuses its captured read rather than walking Git twice. Completion checks the canonical exact order checkout, not a substring: retained P1970 does not block P197. No new type, stored flag, duplicate registry, reader-level .git probes or broad catch.Real command acceptance
Normal installed
agent-comms-commanderentrypoint with explicit source selection, real persistent private bus, actual rule-review records, actual original order/check, real Git worktree metadata and no user orders/provider input. The shared worker home is namedP197-applicationand has no .git.Baseline:
Branch:
Branch with an actual unreleased
worker--P197Git worktree:The refused attempt records no delivery. Tests additionally retain an actual P1970 worktree and require P197 to complete.
Verification and owner ruling
PYTHONPATH=src, externaltimeout 300,-X faulthandler.{}, no other positive deltas. No budget was self-granted and no counter was suppressed. Accepted by the commander ruling in message 3617: line growth is not a defect, this result does not block review, and P276 deletes the measure. This is an explicit owner ruling, not a claim that the recorded src command exited zero.2b1015751e1d411cdefdab9aacebc92aa5e230fb; no clone/install/fallback.45384f54d(see below); no runtime installation or installed acceptance is claimed here.Retention
Source branch
fix/order-checkout-homeremains published at the head above. The existing/home/ts/wt/pi-worker-cpu--P250checkout has subsequently been reused for P276; no third checkout was created. Evidence:/home/ts/.cache/agent-scratch/pi-worker-cpu/checkout-home/, including original baseline/positive/negative command logs, ratchets, AST receipts and tests. Private bus records and original refusals are retained. Completed disposable test trees are retired after borrower checks.Assumed:
Reopen request: already merged
Message 3617 requested reopening and ready status. GitHub refused reopening with HTTP 422:
state cannot be changed. These commits are already merged.Verified the exact head2964a0fcbis an ancestor oforigin/maincc736472f; batch merge45384f54dis titledMerge #2006. Main containsUnitStorage.extra_checkoutsand the exact-checkout completion check. The PR remains closed because its commits have landed, not because work is parked. No source changes or tests rerun for this status correction.