Repository navigation
Conversation
Rotate crashed with AttributeError: 'MergedProblemOrder' object has no attribute 'serves', since PlanPhase.serving reads every order's phase and #2004's merged order kept none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
…ll never races a checkpoint Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… phase only Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Src-Budget: 5
Contributor
Author
|
Closed: the serves property forwards to the wrapped order (IMPL-4). The fix is folding MergedProblemOrder into CheckedProblemOrder, ordered to pi-plan-claims on #1928. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rotate crashes on every tick since a679979:
AttributeError: 'MergedProblemOrder' object has no attribute 'serves'. PlanPhase.serving (plan_phases.py:45) reads each order's phase; #2004's MergedProblemOrder keeps its original order and already reads its id from it, so it reads its phase from it too.🤖 Generated with Claude Code