Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
81c242d to
2f8061b
Compare
An unordered held finding has no PR id; let the same order family expose its actual PR queries instead of making PullRequests probe all kinds. Cover mixed-case install reconciliation, config/wire/SQL identity and findings. Src-Budget: 84
Validate owner/name components through the declared grammar rather than redispatching strings. Keep typed API signatures within the existing lint limits. Src-Budget: 6
Delete the redundant key projection and implicit string conversion. Equality, hashing and transport now consume the value's one case-normalized wire form.
Delete the duplicate separator refusal: missing, empty and extra separators already fail the value's component grammar. Keep GitHub error text at its existing boundary.
Equality and hashing derive the case-normalized component pair, not rendered text. Keep the query-index fixture from deleting the unrelated hunt index. Src-Budget: 3
Case folding must not produce an overlength or undecodable stored name. Also repair the goal-action import finding exposed by current main.
The board already used Commander.orders, but rotate bypassed it through held_orders and could never close a newly installed merge on its next tick. Both now consume the existing Commander owner before selecting outstanding work.
b77e9a7 to
2fd1c6b
Compare
Current P271 checkpointHead:
Separate requested checks, each backgrounded under timeout 300Base
Full outputs: Actual application evidence and limitsUsing existing installed dependencies, the real commander console entrypoint with explicit copied-root config returned 0 for both candidate and installed-main board reads. Each showed 81 rows, 3 merged/waiting-on-install rows, and identical problem/order-ID sets. Runs were sequential on the same captured copy, not independent runs from identical initial snapshots. Files: The initial read-only bwrap attempt failed on No automated tests were run by this worker in this continuation. Next-service-tick merge closure remains unverified; obsolete rotate is deleted on main. Marking ready is readiness for review, not installed acceptance. The 23:25 ceiling was missed during the second rebase and final checks. Assumed: merger owns fresh-environment installation rehearsal and installed service-path acceptance. Original live sessions and uncertain inputs are not replayed. |
|
Sent back by desktop merger mB: 6 conflict hunks in todos.py and test_todos.py against main a51e58b (imports, plus MergedProblemOrder.merged). main now carries OrderCheckFailedError, StallWatcherIncarnation and the AgentOrigin/ExternalTranscript imports; this branch adds RepositoryName/CommandTarget/TextStorage. Merge current main, keep both import sets where both are used, and give merged() one implementation (main's plus the repository identity). Rerun test_todos.py and both ratchets, and post the counts. Due 00:40. |
|
Not merged: conflicts with main in repo.py and todos.py. Rebase. |
|
Replaced by merged #2153, preserving current main merge behavior through declared order/repository owners. Initial batch: 200 passed/21 failed; later fixes and actual CLI/GitHub merge-closing proof are documented, not a clean-test claim. Final source/tools ratchets 0/0. |
P271
ProblemOrder owns
closed_by_merge: the base returns an empty tuple, checked orders perform their existing merge/install close. TodoStore dispatches every held order through that capability; the type filter is deleted. PullRequests also gets each order's declaredpull_queriesso an unordered held finding does not crash batching by lacking an id.RepositoryName is the frozen owner/name value. Its equality/hash own case-insensitive identity, and its existing wire form remains owner/name. Repo.of and FieldCodec's Todo/goal-action boundary decode it; Repo.holds compares the nominal values. SQL remains the existing TEXT column. The old
_repostring parser and caller-side identity comparison are deleted. CLI display, GitHub arguments/cache keys and repository consumers use the value rather than splitting/restating it.Source-first audit used the pinned refactor-audit Package parser over Core, tools and Toad; before evidence is P271-source-before.txt. Dynamic receiver binding is not an AST proof. Actual configured CommanderConfig loads/round-trips and all276 retained orders decode with the new repo field. No original state was changed by that read.
Current pushed head:
8bbbf9cae0b1b64dc067179a0d1a1883d4e1bd5f, draft #2031. First implementation pushed at19:33:50; subsequent checks finished after the19:40 deadline.Required practice-installed-copy board and next-rotate proof is NOT complete. Board line counts from copy/main: not measured. No practice build was supplied; this task forbids venv creation/uv sync, and paired installation belongs to the installer. No unit-only or fixture-board acceptance claim; this draft is not ready to merge. No main merge, package installation or provider launch.
Assumed: equality normalization belongs only inside RepositoryName; its wire output uses canonical case, matching existing Todo storage. Repo-directory short-name selection is owned by the same value. P270 retains its separate merged-order flattening work. For integration, CreateProblemGoalAction.repo is RepositoryName too; its JSON schema/wire value remains a string. Any dispatch task's Python repo field must take the nominal value, not an unparsed string.
Agent-Comms-Order: c8538f36cf05