Repository navigation
Conversation
trissim
marked this pull request as draft
October 20, 2026 00:34
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
force-pushed
the
fix/p284-core-parked-state
branch
from
October 20, 2026 00:36
0d6bab1 to
10bc57e
Compare
trissim
force-pushed
the
fix/p284-core-parked-state
branch
from
October 20, 2026 00:43
10bc57e to
2b0b88a
Compare
Contributor
Author
|
Closing stale draft: no commit since yesterday and nobody has mentioned it on either commander's bus since midnight. Branch kept; reopen with a current owner if the work is still wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P284 — Core owns parking and the stall watcher
Implementation checkpoint, not accepted or installed.
Thread.parked, default false.Registration.set_parkedwrites it under the existing registry editor; ordinary registration preserves the stored value.CommanderConfig.parkedand the stall reader of machine-local configuration.WheelSpinandUnownedWheelSpintotodos.py; the connector imports the watcher there.FlatWheelSpinconsumes the shared Core base rather than duplicating eligibility. NoUnownedWheelSpinforwarding import remains.Goals.reassign; notification still uses the existing messaging owner. No local-import workaround.ParkedThreadsCarry, discovered through the existing carry chain, decoding the retired field through the existing CommanderConfig model and writing through Registration.Before AST census: 381 production modules, no parse omissions. Owner declarations and parked/idle/stall consumers recorded under
/home/ts/.cache/agent-scratch/pi-toad-flash/P284-*.Verification still in progress
Focused watcher tests pass; carry preservation and copied-bus acceptance are being finished. A broader run exposed existing progress-test failures on the starting main; no unrelated progress repair is included.
Main advanced from 7c50ad3 to 94f29a3 during implementation. Comparing the old branch directly against current main therefore also measures the absence of the newly landed #1935 owners. No merge-main commit was made under the order. Current-main integration and its final ratchets remain pending.
The existing
upgrade_bus.py --rehearsealways creates temporary worktrees and runsuv sync; both conflict with the order's narrower no-environment / checkout restrictions. Full installer rehearsal is not claimed. A copied-bus carry and actual watcher pass will be reported separately; those are not substituted for an installer pass.Assumed: parking excludes automatic replacement selection, without cancelling a current turn or changing manual assignment authority. No live registry, goals, sessions, installer or provider input is modified by verification.
Agent-Comms-Order: c966e1ebd067