Skip to content

Keep parked thread state and the stall watcher in Core - #2047

Closed
trissim wants to merge 4 commits into
mainfrom
fix/p284-core-parked-state
Closed

trissim wants to merge 4 commits into
mainfrom
fix/p284-core-parked-state

Conversation

@trissim

@trissim trissim commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

P284 — Core owns parking and the stall watcher

Implementation checkpoint, not accepted or installed.

  • Added Thread.parked, default false. Registration.set_parked writes it under the existing registry editor; ordinary registration preserves the stored value.
  • Removed CommanderConfig.parked and the stall reader of machine-local configuration.
  • Moved WheelSpin and UnownedWheelSpin to todos.py; the connector imports the watcher there. FlatWheelSpin consumes the shared Core base rather than duplicating eligibility. No UnownedWheelSpin forwarding import remains.
  • Reissued Goal publication belongs to Goals.reassign; notification still uses the existing messaging owner. No local-import workaround.
  • Added ParkedThreadsCarry, discovered through the existing carry chain, decoding the retired field through the existing CommanderConfig model and writing through Registration.

Before AST census: 381 production modules, no parse omissions. Owner declarations and parked/idle/stall consumers recorded under /home/ts/.cache/agent-scratch/pi-toad-flash/P284-*.

Verification still in progress

Focused watcher tests pass; carry preservation and copied-bus acceptance are being finished. A broader run exposed existing progress-test failures on the starting main; no unrelated progress repair is included.

Main advanced from 7c50ad3 to 94f29a3 during implementation. Comparing the old branch directly against current main therefore also measures the absence of the newly landed #1935 owners. No merge-main commit was made under the order. Current-main integration and its final ratchets remain pending.

The existing upgrade_bus.py --rehearse always creates temporary worktrees and runs uv sync; both conflict with the order's narrower no-environment / checkout restrictions. Full installer rehearsal is not claimed. A copied-bus carry and actual watcher pass will be reported separately; those are not substituted for an installer pass.

Assumed: parking excludes automatic replacement selection, without cancelling a current turn or changing manual assignment authority. No live registry, goals, sessions, installer or provider input is modified by verification.

Agent-Comms-Order: c966e1ebd067

Copilot AI balanced review requested due to automatic review settings October 20, 2026 00:34
@trissim
trissim marked this pull request as draft October 20, 2026 00:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim force-pushed the fix/p284-core-parked-state branch from 0d6bab1 to 10bc57e Compare October 20, 2026 00:36
@trissim

trissim commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Closing stale draft: no commit since yesterday and nobody has mentioned it on either commander's bus since midnight. Branch kept; reopen with a current owner if the work is still wanted.

@trissim trissim closed this Oct 20, 2026
@trissim
trissim deleted the fix/p284-core-parked-state branch October 20, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants