Repository navigation
Read carry parents and ordering from the target tree - #2054
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
marked this pull request as draft
October 20, 2026 01:00
trissim
marked this pull request as ready for review
October 20, 2026 01:09
trissim
added a commit
that referenced
this pull request
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P288 — target-owned carry parent discovery
Published head: 2a362e2. Ready for code review; fresh-environment installation proof remains with the merger under 3986.
Change
CarryChain's step reader reads the target revision's tools/cutover/carry.py once. Step.declared and Step.holds_carry take that same parent map. EditedCarry reads the base revision's map when checking its old steps. No running-checkout globals() scan remains.
A name set alone would lose TodoColumnCarry.precedes and change ordering. The parser therefore compiles only the target Carry headers and ordering methods into an isolated planning namespace. Python owns inheritance/C3 and the target's actual ordering implementation; no target Core/step module imports, fallback roster, new-parent allow-list or copied precedence decision. Protocol/namespace identities derive from their declarations. Static parent references decode once; unsupported expressions fail explicitly rather than becoming None or a sentinel.
Verification
Merger acceptance still owed
Run #2036's actual fresh-environment --rehearse installation and report its carry line and installed target readback SHA. No such installation result is claimed here. Instruction 3986 assigns that environment creation to the merger; the worker order forbids venv creation/uv sync, so the narrower reading uses existing dependencies for source and retained-state checks.
Assumed: P288 precedes the separate P280 atomic-staging repair. No main merge, fallback or allow-list. No provider/input replay, production mutation, installation, restart or goal resume. Original sessions and UNKNOWN inputs preserved.
Agent-Comms-Order: 1d6661ac1b45