Repository navigation
Parity row 8 verdict comparison and the failed-check strike in deletion parity - #2320
Merged
Merged
Conversation
Parity row 8 had no comparison on main. VerdictComparison runs one real native edit in LifecycleRun's copied bus, judges it through judge.py's OkVerb/BackVerb and through CommsVerdictTool, and requires the same verdict, Todo revision, strike, Goal revision and committed Goal history from both. The edit helper is a real verdict_edit.mjs file, not JavaScript held in a Python string. Rebuilt on main from fix/parity-row31-failed-check (0ffc6ff..389d4f5). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main records a FailedCheckStrike when a delivery fails its order check (todos.py check_failed), but deletion parity still required the refused Todo to be unchanged, so it asserted a state main no longer produces. The check now requires exactly that one strike, made from the prior assignment, as the only change to the Todo, with both thread Goals unchanged. Rebuilt on main from 188651e. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilt
fix/parity-row31-failed-checkon current main.Tests:
tests/test_commander_parity_verdicts.py,_delivery.pyand_measurements.py: 5 passed (one run, timeout 300). Ratchets run hosted in the queue.Kept (main lacks these):
VerdictComparisonandVerdictCaserun one real native edit in the copied bus. They judge it throughjudge.pyand throughCommsVerdictTool, and require the same verdict, Todo revision, strike, Goal revision and committed Goal history from both. The edit helper is a realverdict_edit.mjsfile again, not JavaScript in a Python string (BOUND-5).FailedCheckStrikewhen a delivery fails its check (todos.py:179), butdeletion.pystill asserted the Todo was unchanged. The check now requires exactly that one strike and nothing else.Dropped (already on main through the #2118 line): the delivery, handoff and BoundedRun parity commits, and the
review-like-linus.mdedit (that file is deleted on main).🤖 Generated with Claude Code