Repository navigation
Conversation
…ly edits or ratchet mixin moves Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-function catalog policy Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…5-intel) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
e55e2ec restored compiling every registered kernel before the execution server reports ready, but ffba842 admits child cache workers only through os.sched_getaffinity, which macOS lacks, so macOS compiled every kernel serially in the server. On the macos-15-intel runner the cold catalog then took past the 300 s installed-GUI acceptance deadline (discovery 113 s, serial kernel compilation still running at 290 s). macOS has no affinity API: every online CPU is schedulable, so its capacity is os.cpu_count(); Linux keeps its affinity set and Windows (no fork) is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ry profile [r1 cold-intel] Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # tests/unit/test_named_checkpoint_publication.py
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ame; handoff Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… docs changes) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Passthrough helpers sit on the group scope and reuse the manifest's path-aligned record lookup; the four unused main-window theme methods are deleted and guarded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The theme-method deletion took the @singledispatchmethod line with it, so the class body failed at the first .register. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
U4 moved the connection spec to formbridge, where transport_endpoint takes the config; the smoke still called it without one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-intel] Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…first use Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…cold-intel] Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Closing: the owner's decision is that kernel compilation stays in function-catalog preparation, so it never lands in execution time. This branch's own measurements agree (first pipeline run 18-33 s slower with first-use compilation). The independent parts (parse installed requirements once per process; discovery cost) move to a new branch that keeps catalog-time compilation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
RegistryService.prepare_in_current_process(run by an execution server before it binds, and by the GUI's catalog child) discovered the catalog and then ran every registered callable's preparation hook, JIT-compiling every Numba kernel. Onmacos-15-intelthat was 69.7 s discovery + about 222 s kernels = 301 s against the smoke's 300 s deadline (run38155492658).Local breakdown (Linux, serial, empty caches): 123.8 s total = 18.5 s discovery + 102 s Numba compile self time (665 compilations of 321 functions, largest 4.7 s) + about 3 s. Imports are small (
-X importtime: nothing above 0.7 s).Change
prepare_in_current_processno longer prepares callables, forks cache workers or publishes signatures. A callable's kernels are prepared when a pipeline first uses it, whichCallableContract.from_prepared_callablealready owns. Every kernel iscache=True, so Numba's own keyed disk cache carries them to forked workers and later starts; no new cache._openhcs_requirementsparses installed metadata once per process (it was parsed 613 times, 63 138Requirementobjects).Local cold readiness: 123.8 s to 21.1 s, 0 compilations.
Guard
tests/unit/test_catalog_readiness_work.py: readiness performs 0 Numba compilations and 0 preparation operations; first use of one callable completes at most one operation per target and compiles kernels from its own module only. Counts, not seconds.Certificates
from_prepared_callable).Verification
157 passed.guardrails rc=0.SMOKE_SKIP_GUI=1 smoke_local.sh:7 passed,smoke rc=0.1 failedin 436 s. The first case raisedOpenHCS ZMQ client entered without a connected endpoint; the other 29 were skipped; no values were compared. This is the known port-collision symptom, but this PR changes server startup, so it is not ruled out as the cause. Do not merge before a 30/30 run.38218985682before and38220080786after were still queued).Draft because
.github/workflows/r1-debug.yml,.github/r1-debug/) is still present; delete after the Intel runs are read.prepare_in_current_process.PreparationCacheBatchand its workers now have no production caller; deletion is listed in the receipt.R1c · PR pending · guards 1/1 · see receipt
docs/refactor/consolidation-20261009/R1c-cold-start.md🤖 Generated with Claude Code