Skip to content

WIP: consume explicit ObjectState field states - #1243

Draft
trissim wants to merge 7 commits into
mainfrom
fix/objectstate-declared-fields
Draft

trissim wants to merge 7 commits into
mainfrom
fix/objectstate-declared-fields

Conversation

@trissim

@trissim trissim commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Companion to ObjectState #62, implementing #32 and then #46. Not ready to merge or install. Constructor-patching scopes are removed; explicit Inherit and Unset replace inheritance through None. Qt input state and native signal subscriptions are being moved into the existing shared input mixin rather than retaining duplicated None decisions. Producer core resolution and six real Qt controls have targeted checks; remaining form-manager, nested/inline input, saved-code, field-handle and installed application paths are unfinished. No complete migration or application-readiness claim. Original sessions and other owners worktrees are untouched.

@trissim

trissim commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator Author

Typed field members across the bridge boundary

Paired source checkpoints: ObjectState 1479884, FormBridge b7c4ad5, PyQt f0acb19, OpenHCS 8d3bac264. Not shared-installed and not completion of the wider field cutover.

Owner and consumers

  • FieldInspection retains raw and resolved as FieldValue members. The two null-presence properties are deleted.
  • FieldValue is dataclass-declared. Unchanged python-introspect MemberFamily (main a9428c3) already owns tagged abstract-dataclass encoding/decoding. No new codec, wrapper, case roster or registry was added.
  • Shared bridge semantic DTO fields carry members, not nullable values plus two booleans. The four compact-presence re-derivations and redundant action-field overrides are deleted. Compact serialization uses the declaration-aware codec before selecting keys, preserving Value(None), empty/false/zero, Inherit() and Unset() tags even with previews.
  • Payload exclusion yields explicit absence for an excluded datum and retains directives; previews remain bounded display metadata. No exclusion fabricates literal null.
  • Field-list compaction maps concrete data through the member. OpenHCS help/rendering consume member behavior; the obsolete null-as-inheritance summary counters are deleted.
  • DataclassFieldAccess.is_config_type/is_container owns configuration classification: meaning members being dataclasses must not make them configuration containers. Extraction, reconstruction, structural leaves, history, context and form selection use that owner. Code-editor updates use it and canonical raw reads; duplicate nested recursion and three replaced/dead helper paths are deleted.

Source evidence

NRA SourceModule, module_syntax_index, build_class_family_index: 1,589 production/dependency modules, 9,923 class rows before/after, zero parse omissions. Evidence uses the producer, FormBridge, PyQt, OpenHCS, Toad, Core, current python-introspect and pycodify roots. Syntax/family evidence does not prove dynamic aliases, decorators, MRO or behavior.

Exact search after migration:

rg -n 'raw_value_is_none|resolved_value_is_none' across all five owned source and test roots: 0 hits, exit1, stderr empty. Original two inspection properties, two DTO fields and four re-derivations are gone.

Evidence root: /home/ts/.cache/agent-scratch/objectstate-declared-fields/; dto-members-{before,after}.json, dto-member-call-sites-before.json, dto-member-fixture-migrations.json, dto-null-flags-after.txt.

Confirmed behavior

Real Qt form/native typing, production Qt main-thread dispatcher, authenticated localhost ZMQ server/client, declaration-aware DTO decoding, mutation/catalog, reset, original-handle history undo, absence and view/server disposal pass. Explicit wire examples: {"Value":{"value":null}}, {"Value":{"value":""}}, {"Value":{"value":"None"}}, {"Inherit":{}}, {"Unset":{}}. Final journey also uses the existing metaclass-registry source required by OpenHCS. No provider or original saved input was used.

  • 66 distinct producer cases pass: 64 in the first batch and two old source-generation assertions corrected and confirmed separately. Their former None-as-inheritance expectations contradicted the declared contract; strict literal-null and explicit-empty-config assertions replace them. Initial failure output retained.
  • 43 focused FormBridge cases pass, including typed/compact member roundtrips, malformed-member rejection, code-editor updates and real ZMQ transport.
  • 68 focused Qt cases pass.

Receipts: dto-member-bridge-{journey,paired-final}.txt, dto-producer-tests-v1.txt, dto-codegen-correction.txt, dto-bridge-tests-v1.txt, dto-qt-tests-v1.txt.

Remaining application blocker

OpenHCS tests do not reach collection. The old installed metaclass-registry lacks testing; using the unchanged required source clears that import and exposes TypeError: LazyNapariDisplayConfig.colormap must be str; got Inherit during configuration startup. This wider lazy-validation cutover remains doctrine-owned under the existing unfinished field work. No skip, timeout increase, alternate test harness or installation was used. Receipts: dto-openhcs-{tests-v1,paired-tests-v1}.txt. The OpenHCS consumer source is pushed, not claimed fully application-verified.

@trissim

trissim commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator Author

DTO correction checkpoint (not the completed node correction)

Removed the eleven Python-class-name DTO declarations. All six named DTO deletion checks pass; MIME metadata is retained. Missing and present previews are now members of the existing preview family and own rendering. The renderer no longer tests preview presence. Preview null/type flags are deleted too.

The declaration owner is not derivable from a raw/resolved datum (especially null or absence). UiObjectStateFieldDeclaration now owns its module/qualified symbol and import resolution for remote help; the detached string parser/importer is deleted. Scope/value type-name mirrors have no replacements.

Source-paired verification: 28 checks pass (22 projection/codec cases and six declaration gates). The classifier gate remains failing and is explicitly excluded from this DTO-only result. The existing real Qt native-input → main-thread dispatch → authenticated localhost ZMQ → DTO decode → reset/history undo → disposal journey passes, including literal null, empty text and the string None. No provider, original saved input, build or shared installation was touched.

Initial failure evidence: /home/ts/.cache/agent-scratch/objectstate-declared-fields/node-deletion-gates-before.txt retains all eight expected deletion-check failures on the rejected heads. Current results: node-dto-checks-v1.txt, node-dto-bridge-journey.txt; constructor migration evidence: node-dto-fixture-migrations.json in the same evidence directory.

Still unfinished: operation-owning configuration/leaf values, removal of classifiers and the full application path. Normal OpenHCS startup still has the previously retained lazy Inherit validation failure; no application acceptance is claimed. Native Sending remains deferred and unchanged.

@trissim

trissim commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator Author

Declaration-owned checkpoint (source-paired, not installed)

Pushed heads: ObjectState 93eae56; FormBridge b5d3af8; PyQt 8690060; OpenHCS f0c07c4. Dependency python-introspect ffcffaa (PR #25).

ValueDeclaration compiles annotations once. ParameterOwnerDeclaration owns parameters, field_types and init_field_names (one definition each); constructor and configuration owners share that implementation. FieldValue.of only preserves meaning members or boxes data; it does not classify runtime payloads. Named configuration access is absent on scalar leaves. Declared collection element types own traversal and serialization. DeclaredValue shares metadata/copy/serialization lifecycle between configuration and collection values.

InheritedDefault is the single frozen class-keyed default record; ValueDefault/FactoryDefault materialize it. own_default and inherited_default now index declared fields and raise KeyError for unknown names. Their direct resolver callers validate against the requested declaration; configuration_mro(field_name) filters ancestors by their declared fields before reading defaults. All touched production roots have zero _inherited_default, _resolve_type and __objectstate_rebuild__ references. UIParameterVisibilityPolicy owns field visibility metadata, keyed by the existing policy class. CompactFieldProjection is also its own metadata key; no string-key compatibility reader remains.

Text-line counts (published baseline -> checkpoint):

| production root | is_container | is_config_type | literal | None | getattr | get_base_type_for_lazy |
| --- | --- | --- | --- | --- | --- |
| ObjectState 1479884 | 27 -> 0 | 2 -> 0 | 94 -> 91 | 37 -> 16 | 46 -> 2 |
| FormBridge bdafb52 | 3 -> 0 | 6 -> 0 | 480 -> 468 | 18 -> 16 | 8 -> 0 |

The two remaining lazy callback-name lines are its definition and register_type_resolver registration; zero callers, imports or exports remain in the touched production family. The normalization wrapper/cache and per-caller fallback expressions are removed. Archived dirty-before normalization count was 45, now 2.

FormBridge FieldValue.of: published 3 -> 2; archived dirty-before 15 -> 2. get_base_type_for_lazy: 8 -> 0. metadata.get: 4 -> 2. Combined requested regex: published 15 -> 4; archived dirty-before 27 -> 4. The remaining FieldValue.of sites preserve DTO meaning after mapping JSON data, not payload kind. The remaining metadata.get sites read canonical runtime code-document tokens, not declaration metadata.

widget_creation_type consumers: WidgetCreationPipeline.init selected an enum by the string; it now calls param_info.creation_type(WidgetCreationType). ParameterFormManager._create_parameter_widget only logged it; it now logs the actual info class. All four string ClassVars are deleted.

NRA syntax/family evidence: 1,590 production/dependency modules, 9,953 classes, no parse errors. AST calls: ObjectState getattr 28 -> 13, FormBridge 17 -> 15; is_container/is_config_type calls zero, is_dataclass exactly one annotation compiler call. Dynamic resolution is not established by these syntax counts; the actual source-paired journey below checks the affected behavior.

Exact deleted Python type-name DTO declarations remain: source_type (1), object_state_path_type (2), raw_value_type (2), resolved_value_type (2), object_type (3), help_target_type (1). Genuine mime_type is retained. Deletion gates cover the exact declarations, not all *_type fields.

Verification: python-introspect public resolver/analyzer 64 passed; producer declaration/handle/inspection/scopeless/codegen/deletion cases 51 passed; bridge DTO/deletion cases 29 passed; Qt declared/numeric cases 66 passed. Actual source-paired native Qt input, main-thread dispatch, authenticated localhost ZMQ, DTO decode, reset, undo and disposal passed with null, empty string, text None, inheritance and absence. No provider and no installation.

Still unfinished: OpenHCS config startup reaches SourceBindingsConfig.post_init but attempts to iterate Inherit in its source-binding normalization. Earlier removed has_value reads in the shared normalization owner are repaired; the whole remaining post-init normalizer needs a directive-aware owner pass. The old test_subfield_semantics.py still imports deleted MISSING/string APIs and fails collection; this failure is retained, not skipped or xfailed. Full OpenHCS/app acceptance and #32/#46 cutover are not complete. doctrine-segment remains the implementation owner.

Dependency: python-introspect ffcffaa, draft PR #25. No shared runtime publication/restart performed.

@trissim

trissim commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator Author

Checkpoint 560b443 restores real source-paired PipelineConfig construction. Shared source-binding declarations have one base, raw Inherit/Unset survive normalization, compiled plans reject directives, and seven direct application API checks pass. This is not final P44 acceptance: owner review correctly rejects the remaining per-field normalization roster and explicit parent post-init calls. Both are being replaced in this PR by field-declared transforms, complete declaration iteration and cooperative C3 lifecycle. The OpenHCS pytest run is retained as blocked by unbuilt native extensions after pairing PolyStore source; no skip/xfail or installation claim.

@trissim

trissim commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator Author

Fresh direct-task checkpoint addressing the source-plan roster/C3 review; this does not resume the blocked P44 goal or claim final P44 acceptance.

Published source pairing:

Ownership and deletions:

  • _SourceBindingPlanBase iterates dataclasses.fields(self), indexes each resolved annotation, admits its raw member through ValueDeclaration, normalizes data through that declaration and validates the result. Inherit/Unset remain directives via member behavior, not flag tests.
  • SequenceDeclaration owns declared list/tuple shape conversion; NullableDeclaration composes it without interpreting payload shape. Object-annotated sequence payloads remain opaque.
  • Only actual extra behavior is field-declared under SourceFieldTransform: bindings uniqueness/coercion, grouping cleanup, metadata schema merge and stack components. Validated transforms consume validated input; coercing transforms validate their output. No string-name normalization roster remains.
  • Both normalization and annotation-validation mixins call super().__post_init__(). DataclassPostInit is their shared cooperative endpoint. Deleted SourceBindingsConfig.__post_init__, CompiledSourceBindingPlan.__post_init__, _normalize_field, _tuple_values, _validate_field_value, and obsolete forwarding helpers/imports.

NRA source evidence: 54 relevant production modules across ObjectState, FormBridge, PyQt, python-introspect and OpenHCS parsed; zero parse errors. Before/after source-plan roster calls: source_bindings.py 5→0, config.py 5→0. Explicit named-parent post-init calls: 2→0. Declaration, inheritance, write/check/call and consumer sites are retained at /home/ts/.cache/agent-scratch/objectstate-declared-fields/declared-source-plan-nra.json. Syntax is not proof of dynamic alias resolution; actual C3 is separately exercised below.

Verification:

  • 79 python-introspect focused tests passed, including getter-owned validation/error identity and a cooperative trailing preparation capability.
  • 57 ObjectState focused tests passed, including declaration shape normalization and opaque scalar payloads.
  • Seven direct source-paired application API checks passed: raw directives, both source-plan owners' normalization/rejection, compiled directive rejection, shared declarations and real PipelineConfig construction with inherited Napari colormap gray.
  • Additional real application API checks passed: a new declared field normalizes/validates with no roster edit, a field-declared transform executes, an additional C3 capability executes once after normalization, and compiled annotation validation still rejects directives. Actual MRO: CooperativePlan → CompiledSourceBindingPlan → SourceBindingDeclarationsMixin → _SourceBindingPlanBase → AnnotatedDataclassValidationMixin → TrailingInit → DataclassPostInit → ABC → object.
  • Added corresponding OpenHCS unit regressions; OpenHCS pytest itself remains gated by this checkout's previously reported unbuilt native extensions. No skip, gate bypass, installation, full-suite or full P44 claim. All three PRs remain drafts.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant