Repository navigation
Consume the destructor-safe PolyStore 0.2.18 release - #127
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
external/PolyStoregitlink fromd861ef8(v0.2.17) to the tagged6534b10e(v0.2.18)polystore>=0.2.17,<0.3topolystore>=0.2.18,<0.3Why
PR #126's Official30 teardown reproduced an ignored finalizer exception after module globals had begun clearing:
PolyStore PR #9 removed the duplicated Fiji/Napari
__del__overrides and moved teardown onto the singleStreamingBackendauthority with optional-logger diagnostics and detach-before-close ownership transfer. PolyStore then released that as0.2.18.A shutdown-ordering probe reproduces the before/after boundary directly:
AttributeError 'NoneType' object has no attribute 'info'StreamingBackend.__del__Audit reconciliation
docs/audits/pr126_authority_delta_review_20260922.mdgains a PolyStore-release section. No page prose required correction: no active page documents subclass__del__,fiji_streaming_system.rstis a redirect stub, andfiji_viewer_management.rstalready states that interpreter finalization is not a second resource authority — which this change reinforces. Exactly one semantic edge (fiji_streaming_system.rst←external/PolyStore/src/polystore/fiji_stream.py) plus the 17pyproject.tomlfloor edges were refreshed; the structural verifier confirms no other JSON field changed.Validation
scripts/validate_docs.py docs/source: PASS (156 files, 26 Python blocks, 155 audited sources)scripts.validate_local_release_floors --wait-for-pypi: all 8 first-party dependencies installable,polystore==0.2.18verified through metadata and the installer indexgit diff --checkclean; submodule pinned at tagged v0.2.18No published version was reused or retagged.