Repository navigation
Scope SaveImages outputs by execution axis - #156
Merged
Merged
Conversation
Introduce a nominal materialization path-scope policy, let the CellProfiler SaveImages adapter select per-axis paths, map its overwrite setting to the write mode, and keep exported measurement paths aligned with the written artifacts. Refs #141.
Collaborator
Author
|
Shared-file crossing update from the blind-analysis integration owner: merged #177 changes only the native ROI writer in processing/materialization/core.py (_write_roi_zip near 2940), projecting existing ImagePayloadMetadata into native ROI metadata. Your core hunk at 2435 is the independent image-output relative-path scope and does not overlap those semantics. Please integrate current main normally; preserve the ROI metadata projection while continuing your image-export scope. No edits were made in your worktree or SaveImages/path_scopes owners. |
Retain both the materialization path policy and current runtime measurement feature import. Local SaveImages/materialization tests: 199 passed, 1 skipped; Black and PR diff checks passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CellProfiler SaveImages used one fixed relative filename for every execution axis. Multi-well runs therefore collided on the same artifact, and exported image measurements could disagree with the path actually written.
This change introduces a nominal materialization path-scope policy and lets the SaveImages adapter select per-execution-axis paths. Single-axis paths remain compact, multi-axis paths include the execution identity, the module's overwrite setting now controls the materializer write mode, and image measurement rows use the same scoped path as the output artifact.
Production validation included a
12w_3crun that produced all 36 expected TIFF outputs without path collisions. The isolated branch also passes 85 focused tests, Black, andgit diff --check.Closes #141