Repository navigation
Adopt lazy PolyStore NGFF imports for fresh execution servers - #187
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
September 29, 2026 13:39
Use the merged PolyStore main commit containing OpenHCSDev/PolyStore#15 and the latest ROI codec fix. Focused local validation: 138 PolyStore Zarr/ROI tests and 20 OpenHCS source/Zarr tests passed.
Resolve the PolyStore pointer against merged OpenHCSDev/PolyStore#15. Focused OpenHCS source/Zarr tests pass on the combined tree (20 passed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
Every fresh OpenHCS execution server imports the PolyStore Zarr backend during registry setup, even when the pipeline uses disk storage. The previous PolyStore revision loads OME-Zarr and Dask at module import, adding about 0.64 seconds to each fresh connection. This PR updates the submodule to PolyStore PR #15, which loads NGFF code only when a Zarr operation needs it. See PolyStore issue #14. Stacked on OpenHCS #186.
Evidence
The same OpenHCS integration code ran the official30 CPU-only
1w_1tsuite with a fresh client-owned server for every observation. All 30 cases succeeded; all 110 produced files matched byte-for-byte.total - compile - execute)Every case spent less time outside server jobs, median -0.731 seconds. Cold server-module import fell 1.523 → 0.900 seconds and three fresh connections fell about 1.81 → 1.17 seconds. Compilation and execution job times varied; this PR makes a startup/total-time claim only. The retained CSVs, figures, reproduction command, and native CP reference are in
benchmark/results/perf_lazy_ome_zarr_20260929/.Validation: 142 PolyStore Zarr/NGFF/FileManager tests passed. The isolated OpenHCS PR checkout passed 43 Zarr-path unit/integration tests, with 2 skipped. The full benchmark used the ordinary ZMQ execution path.