Skip to content

Draft: typed source-bound 3-D point results for blind review - #198

Merged
trissim merged 10 commits into
mainfrom
feat/typed-3d-point-results-20260929
Sep 29, 2026
Merged

trissim merged 10 commits into
mainfrom
feat/typed-3d-point-results-20260929

Conversation

@trissim

@trissim trissim commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Integration checkpoint for #134 and #201.

Implemented: typed MeasurementTable to native 3-D PointROI ZIP with exact fractional Z, feature rows, full source-plane provenance, and result-directory reopening. The viewer projects fractional points into the declared Z domain and selects the exact feature row. The bundled OpenHCS skill now requires persisted/native point-coordinate and feature-row checks. Direct plate streaming carries inventory-owned SourcePixelRef and loads exact backend plane addresses for ordinary TIFF and OME-stack sources.

Local evidence: 50 focused plate/stream tests passed; Black, Ruff F, and diff checks passed. Fresh-source MCP on isolated :91/5791 streamed ordinary TIFF leaves and an OME stack with Z 1-4. A persisted matched synthetic ROI and bright Z3 OME source were visually inspected raw-only, result-only, and combined at one camera/Z/window; fresh-source MCP selected point index 0 with one feature row. The test fixture reproduces the witness.

Not yet accepted: installed user entrypoint and bounded blinded biological QA. The configured MCP child still points to an older checkout and cannot use the new DTO/viewer protocol until reconnect. One unrelated receipt test fixture lacks metadata_handler and fails during calibration; it was deselected from the 50-test pass. Point authoring still needs a reviewed pipeline declaration. Keep held-out/reference answers unopened until pipeline freeze. Coordinate worker/export files with #157. No hosted CI wait is required for this checkpoint.

@trissim

trissim commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

Fresh-source live viewer finding (isolated :91/5791, synthetic archive): result_directory ROI stream succeeded and mounted one native Points layer with one feature row. MCP window state reported the point native Z coordinate as 2.375, but the layer axis_component_values/routed_component_values only contained z_index=[0]. Therefore result-only Z navigation/visibility is not yet correct; PR #198 owns the route-domain fix before merge. Raw image stream separately fails in BioFormats as #201. The owned synthetic viewer and Xvfb were closed after inspection to recover RAM; H002 on :90/5690 was untouched.

@trissim

trissim commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

Checkpoint 156fd04: bundled OpenHCS viewer QA skill now requires exact persisted/native fractional-Z point and feature-row cross-check, plus raw combined-view alignment. Point geometry/navigation route fixes are included. Eight focused tests, Black, skill validation, and live result-only MCP point selection pass. Raw-plus-result acceptance remains blocked by #201; result-only native current_step/int Z label is insufficient evidence.

@trissim

trissim commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator Author

Checkpoint 39a6d0c addresses raw streaming blocker #201 in source. Focused stream/plate/receipt suite: 66 passed, 1 deselected (an unrelated receipt fixture lacks metadata_handler and fails during calibration); Black/Ruff F/diff checks pass. Fresh-source MCP streamed ordinary TIFFs and four-plane OME on isolated :91/5791; OME viewer state has Z 1-4. This is not yet installed-entrypoint or same-coordinate raw/result/combined acceptance.

@trissim
trissim marked this pull request as ready for review September 29, 2026 16:59
@trissim
trissim merged commit e95995e into main Sep 29, 2026
25 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant