Repository navigation
Preserve saved label plane domains in original source builder (#419) - #426
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #419 saved-label geometry admission. Final source head d7e730e (production e6fde72) extends ORIGINAL RuntimePlaneAxisValueProjection.from_source_declaration and SourceImageObjectLabelBuildRequest. The constructor derives exact cardinality/aliases from ORIGINAL SourceImageProvenance and the declared nominal axis; builder consumes that projection and retains domain/geometry validation. No array-rank inference of physical Z, fake spacing, copied geometry, new registry, metadata facade or function-name/type dispatch. Both production files are outside PR394 shared runtime/CellProfiler seams.
Source qualification: 211 PASS through original artifact admission + registered FULL_STACK MeasureObjectSizeShape, runtime values, image output metadata, source spatial domains and original AreaShape controls; 9.629s / 418932KiB aggregate RSS. Both declared axes, singleton and multi-plane data, genuine calibrated per-plane volumes, explicit payload/undeclared-volume contracts, strict missing/conflicting cardinality/shape/IDs and exact provenance/pixels are covered. Independent physical-calibration and paired-source capabilities execute real cooperative super/MRO admission, construction and selection, including strict rejection, without consumer edits.
ORIGINAL pinned R0 PASS, unchanged CI tool3b03785f loaded directly from retained Git objects with Python3.14 and readonly backing: actual production e6fde72 vs main c32447f, BOTH changed production paths, zero positive deltas, exit0,18.286s/95584KiB aggregate RSS. Final head changes receipts only; qualified production/test bytes unchanged. All shards oneCPU/512MiB/no swap/60s. Correct full-context R1 remains unqualified separately; no detector/schema/context omission or stale-count substitution, and no CI wait.
Original geometry red and both failed intermediate guards are preserved, not overwritten. Initial builder metadata absence probe was rejected by R0; unapplied metadata-owner hook was also rejected for god-class growth. Those obsolete proposals are NOT needed or installed: current projection-value ownership removes the violation outside394. Full AreaShape ROW_SEQUENCE vector includes every native missing slot; no claim of sparse-ID final public measurement rows or biological correctness.
Morph DISTANCE is STILL FAILED through the explicit original-executor source reproducer (shape1 instead of1x9x9); later original live module output error1x1 remains unchanged. Only its minimal canonical raw ndarray ABI correction remains referred to394: #394 (comment) . No edits to394 files. No native/scientific jobs, installs, environment changes, original-input replay or cleanup. Parent owns installed original saved-label geometry/EDT acceptance and integration; this PR does not close419.
Durable receipt, exact commands, logs/XML, unchanged original R0 lossless outputs and explicit Morph reproducer: docs/validation/saved-label-plane-domain-419-20261002/RECEIPT.rst. Frozen388 driver SHA d3f259fa unchanged; original saved plan inputs and all failures retained. Existing persistent WT reused, old branches/evidence preserved.