Repository navigation
Expose acquisition-owned physical-source QA inventory (#445) - #446
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #445. Working source checkpoint published; installed/native receiving remains open. This is missing original-channel QA access, not a demonstrated channel swap.
Receiving head bfbfd21; exact qualified production head 1075123, based on main 3df650b. Source tests/R0 are terminal. No CI wait, install, native startup, scientific read/run, process mutation or cleanup.
What works in source
Ownership / NRA
Shared read-only source/workspace resolution belongs on existing PlateImageInventory.from_read_only_handler. The service retains a small dispatch/error-reporting hook. PlateImageInventory.from_source_dataset replaces/reuses the original candidate loop; from_handler retains its old projection precedence. SourceCandidate/SourcePixelRef and the original sampler/stream projector remain authoritative. No new selector API, mode, concrete BioFormats switch, decoder, registry or mirrored catalog.
A fourth-channel declaration and an independent metadata leaf with cooperative super().source_dataset flow through unchanged consumers. No ornamental MI is introduced. Catalog review: BOUND-2/8, MEMB-1/2 and IMPL-12/13.
Singer owns #445 read-only source boundary and separate #404 receiving acceptance. Parent owns integration/native physical-channel QA. Root #394 retains shared source binding/metadata/projection/materialisation. Checked 919fee2 and later a5134a0; neither changed production path overlaps its roster. Exact scope: #394 comment5950317703. No shared/foreign WT edit and no #404 code imported. Planck scientific files/viewer untouched.
Evidence
Original source: 1 RED / 2 PASS, C3 hidden after C1 preparation; 4.60s / 240972KiB. Final owner-corrected source: 5 PASS, 4.87s / 240280KiB; 1CPU/512MiB/no-swap/60s kernel bound. Eleven existing inventory/DTO/path/source-ref controls passed at the first placement; no ceremony rerun.
Unmodified original pinned R0, all actual changed production files included: initial service growth +8 REJECTED, corrected by moving the algorithm to its existing inventory owner. Final PASS, no positive deltas, service excess -13; 17.82s / 87628KiB. No detector copy, excluded path or raised threshold.
Receipt: docs/validation/physical-source-inspection-445.rst.
Byte-exact full archive: docs/validation/physical-source-inspection-445-source-20261002.tar.gz
SHA256 ffc8001ed2d76c43626f6154f84b06fa54a4b1865f209ab4a00212d9b6ccef8a.
Original smaller archive, original red, three intervening harness failures and initial R0 failure are retained. Raw whitespace is not rewritten.
Test: tests/unit/agent/test_physical_source_inspection_445.py.
Parent must still qualify installed public C1/C3 matched raw/composite/nuisance QA. #445 is not auto-closed. #440/#441 installed acceptance and #404 native graph reopening remain independent.