Repository navigation
Document typed producer retirement and measured viewer memory - #526
Merged
Merged
Conversation
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source-only canonical guide update addressing #519 operating-procedure gap, settled head cb6c5ed.
One guide owner
Existing
packaging/codex/openhcs/skills/use-openhcs/references/viewer-qa.mdowns the conditional how-to. Its actual knowledge-manifest source_path remains unchanged. Canonicaldocs/source/guides/viewer_management.rstlinks that guide rather than maintaining a second recipe; only viewer-QA discovery summary/tags change. Existing SKILL routing already reaches the guide. Copernicus explicitly released these seams and owns disjoint measurement prose.Discover the exposed typed retirement contract, retain saved files/declarations/captures/latest matched candidate/raw/reference routes, require known terminal settlement, and submit the complete explicit route→producer incarnation set (including invocation_key) once. Known failed terminal candidates may be retired if mutations are finished and durable evidence is retained. UNKNOWN/in-flight is not disposal authority. Hide ≠ release. Check typed reply and survivor state; use permitted actual process memory telemetry rather than layer/UI counts. Record measured consequences without promising RSS will drop or attributing scientific OOMs to a leak.
Skill-creator keeps this in one existing reference; Diataxis makes it a conditional how-to. No dataset answers, new registry/schema/framework, runtime implementation, live skill sync or target04 changes.
Actual delivery evidence
3 controls PASS: original project_knowledge_assets projects the actual declared sources; original KnowledgeBaseService retrieves both complete documents byte/render-equivalently and discovers the viewer guide; AgentSkillBundle declares the same guide; original sync_skills delivers identical bytes into isolated pytest storage and returns unchanged on the second call. Two existing projection/sync controls are included. This is source/package/discovery/delivery proof, not an agent decision or installed-MCP/native retirement proof.
Original skill-creator quick_validate: PASS. Serial CPU1/512MiB/Swap0/60s: controls6.16s/maxRSS257164KiB, cgroup170.4M; validator0.05s/maxRSS14920KiB. No repeated completed test, build, install, runtime or SCI contact.
Receiving receipt. Byte-exact raw logs/source archive:8members/21615bytes/SHA256 b33b84c63f1597cf8c5e34a43cc2d5dbdd2227e24096b9b100110e208482903c; tar comparison passed every original member. Warning whitespace retained honestly. Full PR diff-check passes; foreign gitlinks/519+503 ledgers preserved, no owned tracked changes remain.
Precise separate receiving gaps
522 does not generally retain untargeted Points/Shapes selected_data across required rematerialization: original mount creates new native layers; active-layer/style retention is not row selection. The actual owners are NapariResultElementSelectionAuthority/NapariResultSelectionController and existing cooperative mount/presentation hooks. This PR records the gap and requests explicit row readback; it does not introduce a production selection mirror or claim a fix.
Later actual target04 MCP construction failed RecursionError before native/viewer launch; original scientific failure/freeze is retained. Planck is ONE combined integration owner. His published91d449a71 corrects the public retirement request annotation to original StreamProducerIdentity (all9fields), using existing typed-or-originalPayloadMapping decoder; no implicit recursive JsonValue carrier, generic tool switch, alternate codec, recursion-limit/timeout increase. Source trace and ownership are recorded in the receipt and522 comment5967387805. New target actual MCP construction/health and native retirement remain separate receiving acceptance. Frozen04 and all SCI installations remain untouched.