Repository navigation
Preserve source metadata in saved spatial graph ROI archives - #550
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saved spatial graph ROI ZIPs carried edge geometry and features but omitted the graph's source declaration. Ordinary native reopening therefore refused the archive for missing source metadata. The existing writer now binds the graph's selected source provenance and coordinate spacing through
ROIArchiveSourceMetadata, and puts the same metadata onOutput. Geometry and subject/edge features remain unchanged; source selection still belongs to the existing graph context owner.This main-based release receives only the already integrated graph writer and its two test files from 45f3a721e. It avoids the broader runtime branch and retains main's current materialization behavior.
Validation on main
eda0121a8plus this change: 23 passed in the graph source roundtrip and spatial graph materialization test files;git diff --checkpasses. Controls cover both declared source planes, complete archive metadata and spacing, exact geometry and subject features, cooperative graph subclasses, and refusal of missing, mixed or conflicting native source metadata. Tests ran on CPU 3. The source-identical existing_tabular_nativeABI artifact was reused locally; no package installation or native client was run.This establishes source/writer/archive behavior. Result-directory publication, installed/public native acceptance, point producer integration, and the broader runtime branch's original R0/R1 obligations remain separate. Historical graph R0 and receiving evidence retain their original source scope in the #404 receiving record; they are not new qualification of this branch. No performance or scientific-run acceptance is claimed.
Refs #404
Refs #134