Skip to content

Preserve source metadata in saved spatial graph ROI archives - #550

Merged
trissim merged 1 commit into
mainfrom
fix/graph-roi-source-metadata-20261003
Oct 3, 2026
Merged

trissim merged 1 commit into
mainfrom
fix/graph-roi-source-metadata-20261003

Conversation

@trissim

@trissim trissim commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

Saved spatial graph ROI ZIPs carried edge geometry and features but omitted the graph's source declaration. Ordinary native reopening therefore refused the archive for missing source metadata. The existing writer now binds the graph's selected source provenance and coordinate spacing through ROIArchiveSourceMetadata, and puts the same metadata on Output. Geometry and subject/edge features remain unchanged; source selection still belongs to the existing graph context owner.

This main-based release receives only the already integrated graph writer and its two test files from 45f3a721e. It avoids the broader runtime branch and retains main's current materialization behavior.

Validation on main eda0121a8 plus this change: 23 passed in the graph source roundtrip and spatial graph materialization test files; git diff --check passes. Controls cover both declared source planes, complete archive metadata and spacing, exact geometry and subject features, cooperative graph subclasses, and refusal of missing, mixed or conflicting native source metadata. Tests ran on CPU 3. The source-identical existing _tabular_native ABI artifact was reused locally; no package installation or native client was run.

This establishes source/writer/archive behavior. Result-directory publication, installed/public native acceptance, point producer integration, and the broader runtime branch's original R0/R1 obligations remain separate. Historical graph R0 and receiving evidence retain their original source scope in the #404 receiving record; they are not new qualification of this branch. No performance or scientific-run acceptance is claimed.

Refs #404
Refs #134

Receive the coherent writer and source roundtrip controls from 45f3a72 on current main. Refs #404 and #134; installed result-directory/native acceptance remains separate.
Copilot AI balanced review requested due to automatic review settings October 3, 2026 20:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit 890b3d9 into main Oct 3, 2026
4 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants