Repository navigation
Preserve current intensity domains across mixed carriers (addresses #599) - #600
Merged
Merged
Conversation
…-intensity-domain-20261004
…-intensity-domain-20261004
trissim
marked this pull request as ready for review
October 4, 2026 12:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mixed raw-code and normalized-image composition (addresses #599)
Existing ImagePayloadIntensityFields owns the shared numerical contract; original
ImagePayloadMetadata composes it with source/domain/spacing capabilities. Original
stack composition reconciles units before dtype promotion, using existing
MemoryType/ArrayBridge for declared devices. Four consumers migrate; replaced
stack helper and duplicated normalization decisions are deleted. No min/max guess,
float-dtype mode, parallel scale store, backend switch or alternate codec.
New independent cooperative mixins work in both MRO orders without consumer edits.
Source 267PASS, final quantization85PASS, memory28PASS and actual CP input2PASS;
original fixture failures remain. Original pinned R0 PASS, all positive deltas
empty. Full relevant AST/dependency source closure/zero parse omissions recorded.
Global NRA R1 hit its original deadline and remains incomplete, not waived as PASS.
Whole ordinary package/RECORD controls and26 asserted-installed checks PASS.
Actual public receiving COMPLETE at source422/target02 via one original recorded
client/native: independent scalar and RGB→monochrome plus forward/reverse arithmetic,
all720 saved public values EXACT, original .5/.5 calibration. Same lease verifies
614 SourceBindings→positions→assembly, all560 mosaic values/nine contributors per
channel. Canonical native VALUES validate expectations. No biology/GPU claim.
Accepted intensity path uses the supported named-artifact-only persistence policy.
Earlier automatic final Reverse publication FAILED; original logs/output/job remain.
Historical435 is closed for its other accepted cases. Same writer guard/family
predates600, but this exact Reverse fixture is not tested on pre600 runtime and
not claimed fixed/independent. A named follow-up owns that distinct remaining risk.
Original exact native close ACK/process_exited/succeeded, native/MCP gone/ports0;
original CLI terminal2 retained from explicit earlier negative inputs, not rewritten.
Normal main09edf integration leaves all six reviewed600 production files identical
to received422. Newer unrelated main/dependency floors are not live-tested here.
Full receipt: docs/validation/mixed-carrier-position-public-receiving06-20261004.rst.
Byte-exact archive SHA25612638e8d8b7b5dcd126f0999d070eb45a395999c5b43d7923c5b3ed440c5f264.
Full source history: docs/validation/mixed-carrier-intensity-domain-20261004.rst.
User authorizes normal merge without hosted CI; frozen SCI targets remain unchanged.
Closes #599