Skip to content

Honor STEP_INPUT origin for named image artifacts (#632) - #633

Merged
trissim merged 9 commits into
mainfrom
fix/step-input-image-artifact-origin-20261004
Oct 4, 2026
Merged

trissim merged 9 commits into
mainfrom
fix/step-input-image-artifact-origin-20261004

Conversation

@trissim

@trissim trissim commented Oct 4, 2026 •

Copy link
Copy Markdown
Collaborator

Owner fix

Closes #632.

Existing SourceUniverseRequest owns the declared STEP_INPUT versus PIPELINE_START origin. STEP_INPUT primary bindings select current processed pixels by provenance, with new or reused names; PIPELINE_START and companion SOURCE_ARTIFACT bindings retain the original workspace loader. RuntimeAdapterRequest deletes its unconditional loader and delegates. SourceSelector shares metadata matching, NamedSourceBinding owns assignment, and ImagePayloadMetadata owns plane/channel projection. Both existing consumers use that resolver; CP supplies its actual current image and honors explicit source origin before coincident name projection.

No new adapter hierarchy, registry, workspace mirror, codec or function_runtime hunk. #630's reviewed head leaves these five production files unchanged; coordination is posted there. Main #626 integrated normally with its separate output-identity hunk. Eight dirty dependency checkouts and four diagnostics remain preserved.

Verified acceptance

  • Relevant production/dependency AST: zero parse omissions; source evidence, not a complete formal proof. Replaced loader and duplicated selector decisions deleted.
  • Qualified offline whole wheel ee9d9e3: complete byte/RECORD and 13 packaged skill projections verified. 411 installed controls passed, including new/reused bindings, multi-plane/missing selection, function/artifact consumers and original CP raw measurements.
  • Actual recorded public MCP: all three synthetic sessions compile and execute. New/reused STEP_INPUT give exact zero label/support masks; opposing PIPELINE_START gives the exact single 36-pixel object. Original raw mean/min/max remain unchanged in each case, acquisition identity retained, and 2048 processed output pixels checked exactly through public sampling. Synthetic input SHA unchanged.
  • Exact native handle acknowledged closure and exited. Recorded client ended with exit1 due to a retained pre-readiness catalog rejection without delivery; all three execution jobs succeeded. Closed journals retained. Earlier high-pressure pre-client refusal remains distinct, not replayed as UNKNOWN.
  • Public proof is pinned to the qualified ee9 wheel; later normal Keep storage extension out of acquisition provenance (addresses #620) #626 merge is disjoint, not claimed as a rebuilt live wheel. No frozen science replay, reference coaching, or frozen-frame equality claim.

Detailed owner/consumer and acceptance receipt: docs/validation/step-input-image-artifact-origin-20261004.rst. Original engineering acceptance: public88/verify-public02.stdout and OWNER-633-TERMINAL.rst under engineering-step-input-origin-633-20261004.

CI deferred under explicit user direction; installed controls and actual public workflow completed.

@trissim trissim changed the title WIP: honor STEP_INPUT origin for named image artifacts (#632) Honor STEP_INPUT origin for named image artifacts (#632) Oct 4, 2026
@trissim
trissim marked this pull request as ready for review October 4, 2026 15:40
Copilot AI balanced review requested due to automatic review settings October 4, 2026 15:40
@trissim
trissim merged commit ef661e1 into main Oct 4, 2026
2 of 38 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

trissim added a commit that referenced this pull request Oct 4, 2026
Preserve the refactored materialization owner while receiving the correctness fixes from PR #638 and the source-origin contracts from PR #633. Keep one live storage-alias rejection assertion. Validation: 12 focused receiving controls passed with unchanged source hashes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

STEP_INPUT named image artifacts can reload pipeline-start pixels after unnamed preprocessing

2 participants