Repository navigation
Derive automatic point and volume-label stream domains from rendered ROI geometry - #748
Conversation
…ation/aggregate-publication-receiving12-20261005
…matic-point-domain-152-20261005
…matic-point-domain-152-20261005
…nt-domain-152-20261005
|
Corrected receiving15 PUBLIC acceptance now verified; supersedes the pending public boundary in the earlier body. Original client17936/native648055 executed packet02 COMPLETE, then ordinary mixed scalar TIFF + fractional Points + two plane-anchored Shapes reopening returned errors=[] and no skipped records. OWNER-748-SAVED-REOPEN-ACCEPTANCE15.rst and OWNER-SCALAR-TIFF15.json retain exact receipts and14 original native PNG witnesses. Parent independently opened XY and trueXZ raw/Points/combined originals, read saved-state/reopen receipts, and read actual TIFF: int32(4,5,7), QYX, four MINISBLACK pages/one sample each, exact eight label7 voxels at Z1/2. Source head5fb production owner/consumer diff reviewed with NRA/refactor-audit; rendered output polymorphism carries geometry, duplicate spec-domain reconstruction/viewer plane reader deleted. Focused AST/source/232 installed controls retain their exact reported scope; not global NRA completeness or supported Napari0.7.1-stack acceptance. Existing source controls are not rerun. Original failed packet01 files and rejected Shapes route-local ordinal1 request remain. Final writer seal/close pending while same client proceeds to independent522 case; not a merge gate for this qualified path. No hosted-CI hold. |
Automatic point/volume-label projection; saved scalar TIFF writer corrected
Working source head 5fb7e14, normally integrated with main6478a2d84. This PR is main-based and contains its own geometry/writer family, not historical Root ancestry or unmerged Singer522 work. Original scientific runs and receiving13/14 remain immutable.
Owner changes
No new axis store, codec, registry, reader fallback, timeout increase, forced view or guard relaxation. Wrong-source, missing-axis, incompatible-channel and undeclared-rank rejection remain intact. Merged802/1c4fa2's uint8 preparation/quantization logic is unchanged; that PR did not edit the targeted TIFF storage configuration method.
Qualified source strength
Original geometry FAMILY10:386PASS and INTEGRATION11:390PASS; focused geometry AST43 source/test+3 dependency files/254 named sites, zero omissions.
New original writer-family invocation51704:153PASS, including24 actual file write/read cases over1/3/4/5 frames, uint16/int32, scalar/contiguous RGB/planar RGB, complete values, header axes/page/sample semantics and original reader; retained compression and undeclared-axis negatives pass. Wall11.25s, peak516220KiB RSS, swaps0. Focused writer AST71 source/test/dependency files:352→362 named sites, zero omissions. These are source controls, not global R1 or corrected installed acceptance.
Exact new receipts under
/home/ts/wt/openhcs-issue-batch-20260929/engineering494/:TIFF-WRITER-SOURCE-QUALIFICATION01.rstTIFF-FAMILY-CONTROLS01.log/.timeTIFF-OWNER-AST-BEFORE01.json/TIFF-OWNER-AST-AFTER01.jsonOriginal installed/public success and retained failure
Receiving14 pins ec3b460 (main121fad + own748a364 + Singer522001a09f), not the new writer head. Ordinary build76868 terminated0; whole proof918RECORD entries/815tracked source/790Python/full13-skill identity. Installed family03:145PASS. Original plugin-import and141PASS/4FAIL fixture negatives remain; the fixture migration changed no production bytes. Actual paired Napari is0.6.1, not a supported0.7.1-stack claim.
Original sole public client97114/native77908/create1791210215.36/viewer369352/create1791211803.41:
Exact original packet/receipts:
engineering494/public748-after73295-attempt01/{OWNER-LIVE-REOPEN-CHECKPOINT.rst,PERSISTED-AND-NATIVE-READBACK02.json,verify-persisted02.time,ADMIN748_95/author-workspace/output/runtime/mcp.stdin,mcp.stdout,mcp.timing}. Failed TIFF and captures remain under/run/media/ts/hdd/openhcs-engineering/engineering748-public95-20261005/packet01/. Original checker01's incorrect per-plane ZIP assertion is retained separately.Corrected installed/public acceptance
Dewey completed original exact typed closure: viewer369352 and native77908 all five close flags true, independent process/endpoint disappearance; original client97114 EOF/terminal2 and three full sealed journals retained. Original failures remain negative evidence. Receipt:
engineering494/public748-after73295-attempt01/OWNER-TERMINAL-CUSTODY.rstandOWNER-CLOSED-JOURNALS.sha256.ONE corrected receiving15 package is now installed-qualified and frozen, pin543bf34669f25e4e8c86ac0007ac9f4cc68f3cc0 (normal mainff9c9ab67, source7485fb, exact522001 hooks, merged809 guide). Original build31920 terminal0:117.95s/443236KiBRSS/Swap0; whole919RECORD/816tracked source/791Python/full13-skill bytes PASS. Original installed23130 terminal0:232PASS,25.92s/633008KiBRSS/Swap0, allfour affected module origins asserted in receiving15/target. Actual retained Napari0.6.1 is stated rather than claimed as0.7.1 acceptance. No new environment, download, shared install or SCI13 mutation. Latest main811/812 changes are paper-only and do not alter the package's production or guide bytes.
Exact immutable pointer:
/home/ts/wt/openhcs-issue-batch-20260929/engineering-pre-first-routing-20261004/receiving15/READY.json(same root READY.rst and31-entry READY-FREEZE.sha256). Wheel SHA256793da8a9f5d2a17267288e3d4b25cbdd6ecb2bdccfa13c3831e8108a032ca174. Initial30-entry seal omitted agents/openai.yaml; it remains separatelyREADY-FREEZE-INCOMPLETE01.sha256. Final31-entry seal includes all13 skill files and ownership metadata. No qualification or build was replayed.New complete public packet:
engineering494/public748-after-writer95-attempt02/{SOURCE-PACKET.json,pipeline.py,RECEIVING.rst}. The pipeline changes only the output destination to packet02/results; producerc883 and original five input files are unchanged. Dewey alone owns successor FUND/public-client launch. Corrected receiving15 public execution and saved reopening are now verified. Original compilejob1 completed; executionjob2/8c48fe80-a0de-4883-9d1e-3b68527afba9 is definitive COMPLETE/errors[]. The actual new int32 label TIFF is QYX, four MINISBLACK single-sample pages; all140 values match the original fixture. Same-viewer mixed scalar+Points+two Shapes ZIP reopening succeeds/errors[]/no skipped records. Scalar and fractional Points retain Z0..3 and scale2/.65/.65; per-plane Shapes retain Z1/2 with corresponding native translations2/4. One Shape route-local ordinal1 request was explicitly rejected; the distinct corrected ordinal0 request succeeds and the rejection remains. No live prefix patch, original-file rewrite, uncertain request replay or CI wait. Singer522's genuine3-to2 selected-source lifecycle and biology/whole historical494 acceptance are separate and not inferred here.Independent persisted/capture receiving and precise limits
Planck read all14 original native PNGs: saved Points raw/result/combined in XY/XZ/YZ, Shapes XY triplet, saved scalar-only and scalar+Points+Shapes. Orthogonal centre/source placement aligns; size3 point glyph obscures the tiny XY raw square, explicitly not a numeric geometry failure. Labels/polygons have source-backed placement; no biological accuracy claim.
Independent original-reader verification16 TERMINAL0/PASS (1.01s,156972KiBRSS,Swap0) checks all140 label values, original four raw file bytes, CSV object7/centreZYX1.5,1.5,2.5, original ROIArchiveSourceMetadata/ROIFractionalZ readers, source paths/domain/spacing, both plane anchors, and every reopened native route scale/translation. Initial verifier15 queried optional per-plane projection indices unconditionally and FAILED; source/stderr/time remain. Verifier16 uses the existing ROIPlaneMetadata.has_plane_metadata contract, never fabricates a plane domain or weakens the runtime guard.
Exact read-only receiving packet:
engineering494/public748-after-writer95-attempt02/OWNER-748-SAVED-REOPEN-ACCEPTANCE15.rstOWNER-EXECUTION-COMPLETE15.jsonOWNER-SCALAR-TIFF15.jsonOWNER-SAVED-REOPEN15.json/OWNER-SAVED-STATE15.jsonOWNER-SAVED-CAPTURE-OPERATIONS15.json(all14 exact paths and original31 request/reply records)PERSISTED-AND-NATIVE-READBACK16.json/verify-persisted16.py/verify-persisted16.timePLANCK-PUBLIC-ACCEPTANCE16.rstSource-reviewed PR head remains 5fb7e14; no new product edit/build is required for paper813/815. Public incarnation is original client17936/native648055/create1791215470.77 on receiving15. That original client continues the SEPARATE Singer522 selected-source lifecycle case; exact final closure/full-journal seal are pending and NOT claimed here. The known terminal748 execution and completed saved reopen are actual acceptance, not inferred from files. Neither old failed job/reopen nor unknown timed-out capture is replayed. 522 acceptance and supported Napari0.7.1 proof are not inferred.