Repository navigation
Reuse cached fixed-size widget boxes when descendant layout changes - #102
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 7, 2026 21:05
trissim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The box cache for widgets with fixed or fill sizes was keyed on descendant layout updates, even though the native box calculation reads only the widget's own styles and the supplied size. This change adds a check in
_measurement.pythat a widget's local styles qualify, andwidget.pythen keys the cache on the style object and its cache key instead. Widgets with auto sizes, fractional widths that depend on content, or custom style or scalar types keep the old keying. A cache lifetime test is extended.