Repository navigation
Close unawaited watcher coroutines when messages are dropped - #104
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 7, 2026 22:02
trissim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reactive watchers that return coroutines could leave them never awaited when the delivery was rejected, abandoned or still queued at shutdown. The watcher callback now owns its coroutine and gets a
_discardhook, which the message pump calls for rejected messages, unrun next-callbacks, and queued messages when the pump exits or is destroyed unstarted. The old free await helper inreactive.pyis removed. Tests are added totest_reactive.py.