Repository navigation
Declare container selection separately from native box measurement - #108
Merged
Merged
Conversation
trissim
changed the title
trissim
deleted the
fix/native-container-selection-declaration-20261007
branch
October 11, 2026 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check for whether a widget is a container was folded into the native box measurement, so a widget overriding
is_containercould not be told apart from the native resolver. This change adds aNativeContainerSelectiondependency in_measurement.pyand attaches it toScrollView.is_container;widget.pycompiles it from the getter's declaration, and undeclared overrides fall back to the conservative height dependency. Native content width and height checks and the relative-children check now consult it. Tests are added totest_height_independent_measurement.py.