Repository navigation
Stop unused grid measurements from blocking arrangement reuse - #110
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 8, 2026 01:02
trissim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GridHeightin_measurement.pytreated content and extrema measurements of every grid child as depending on the incoming height, even though the grid only queries them for auto tracks without spans. The check now looks at those queries only: content height and height extrema for children in auto rows with a row span of 1, and content width and width extrema for children in auto columns with a column span of 1. Grids whose tracks fix the cell sizes can then reuse arrangements at other heights. Tests are added totest_height_independent_arrangement.py.