Skip to content

Import Widget in message dispatch only when selectors need it #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 1 commit into from
Oct 8, 2026
Merged

Import Widget in message dispatch only when selectors need it #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/textual/message_pump.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,8 +879,6 @@ def _get_dispatch_methods(
method_name: Handler method name.
message: Message object.
"""
from textual.widget import Widget

methods_dispatched: set[Callable] | None = None
message_types = message.__class__.__mro__
message_mro: list[type[Message]] | None = None
Expand Down Expand Up @@ -914,6 +912,11 @@ def _get_dispatch_methods(
else:
if not message._sender:
continue
# Widget is required only by selector matching.
# Idle, named and unfiltered decorated delivery
# do not acquire this unrelated type boundary.
from textual.widget import Widget

for attribute, selector in selectors.items():
node = getattr(message, attribute)
if node is None:
Expand Down
Loading