Skip to content

Skip geometry checks when writing styles on a detached node #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 2 commits into from
Oct 8, 2026
Merged

Skip geometry checks when writing styles on a detached node #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6270a8f
Avoid node geometry analysis for detached rule normalization
trissim Oct 8, 2026
02d6d12
Assert child layout intent through its current native owner
trissim Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/textual/css/styles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,10 @@ def _update_rules(
changes = updates + removed
if not changes:
return False
geometry = any(
# Detached styles normalize rules (including mount's prepared copy)
# but have no node geometry to invalidate. Keep validation and rule
# publication intact; acquire placement effects only for their owner.
geometry = self.node is not None and any(
descriptor.affects_geometry(previous, value)
for descriptor, key, previous, value in changes
)
Expand Down
3 changes: 2 additions & 1 deletion tests/css/test_stylesheet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ async def test_style_batch_keeps_child_damage_separate_and_flushes_interrupted_e
parent.styles.refresh(layout=True)
with parent.styles.batch_update():
parent.styles.color = "green"
refresh.assert_called_once_with(layout=False, repaint=True)
refresh.assert_called_once_with(repaint=True)
assert not child._layout_required
assert child.rich_style.color == Color.parse("green").rich_color
with pytest.raises(StyleValueError), parent.styles.batch_update():
parent.styles.color = "red"
Expand Down
Loading