Repository navigation
Measure stream layout child heights at the width they are given - #114
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 8, 2026 04:10
trissim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StreamLayoutmeasured a child's content height using the container width minus the child's gutter, but placed the child at the container width minus its horizontal margins. With margins, the text was wrapped for a wider box than the one assigned. Instream.py, the child width is now computed once from the margins, and the height is measured at that width minus the gutter, never below zero. Only that file changes.