Repository navigation
Keep held widget geometry correct when an ancestor scrolls - #115
Merged
Merged
Conversation
trissim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While a widget's updates are held, the compositor kept the frozen screen coordinates of its subtree, which went wrong if an ancestor scrolled.
_compositor.pynow stores each entry's rendered parent and recomputes the position from the ancestor's current placement and clip, falling back to exact placement for missing, resized, screen-relative or partial captures.screen.pygets a small matching change, and held roots keep their outer geometry when scrolled offscreen. Tests are added intest_viewport_geometry_targets.pyand adjusted intest_batch_paint_admission.py.