Repository navigation
Split Markdown initial document setup out of the mount handler - #116
Merged
Merged
Conversation
trissim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown._on_mountupdated the document and then posted the table of contents notice inline, so a subclass could not take over the update without also blocking its parent's mount. The update now lives in a newMarkdown._initialize_document, which starts the update synchronously and returns an awaitable that also posts the notice when there is no initial text._on_mountawaits it, so ordinary Markdown behaves as before. Tests are added intest_markdown_initial_publication.py.