Skip to content

Walk each ancestor path once in the compositor's held-region scan - #117

Merged
trissim merged 1 commit into
mainfrom
fix/native-held-region-membership-20261008
Oct 8, 2026
Merged

trissim merged 1 commit into
mainfrom
fix/native-held-region-membership-20261008

Conversation

@trissim

@trissim trissim commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex work, mostly replaced. 3 of 18 code lines it added are still in main.

Compositor.deferred_regions walked a widget's full ancestor chain for every widget in the published map to find which held roots contain it. It now remembers, during one call only, whether each ancestor is under a held root, so shared parents are walked once. The regions returned, including the fallback for roots without a placement, are meant to stay the same. Only _compositor.py changes.

@trissim
trissim marked this pull request as ready for review October 8, 2026 06:43
Copilot AI balanced review requested due to automatic review settings October 8, 2026 06:43
@trissim
trissim merged commit 46e7315 into main Oct 8, 2026
0 of 22 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim trissim changed the title Share ancestor membership within held-region geometry reads Walk each ancestor path once in the compositor's held-region scan Oct 11, 2026
@trissim
trissim deleted the fix/native-held-region-membership-20261008 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants