Skip to content

Stop mounting children from blocking the parent's message queue - #120

Merged
trissim merged 3 commits into
mainfrom
fix/native-mount-completion-20261008
Oct 8, 2026
Merged

trissim merged 3 commits into
mainfrom
fix/native-mount-completion-20261008

Conversation

@trissim

@trissim trissim commented Oct 8, 2026 •

Copy link
Copy Markdown

Mounting optional children queued a wait for composition on the parent's next-callback queue, which stopped wheel messages from bubbling through the parent while it waited. await_complete.py now has a shared AwaitCompletion base with a call_when_ready method, and AwaitMount and AwaitRemove use it, so the parent gets its callback only after the mount has finished. Waiters can still await the mount, and cancelling one waiter does not cancel startup. app.py and widget.py are updated to match, and tests are added to test_mount.py.

@trissim

trissim commented Oct 8, 2026

Copy link
Copy Markdown
Author

Integration review: the matched installed Toad App confirms the previous 219ms parent mount-completion callback hold is removed; history callbacks were about 1ms or less. Overall frame pacing still fails, so this is a targeted queue repair. Reviewed shared completion admission, distinct constructors, mount None result, cancellation and removal self-custody. The separate application viewport routing correction preserves native movement and nested controls. Proceeding with matched frontend integration.

@trissim
trissim marked this pull request as ready for review October 8, 2026 12:09
Copilot AI balanced review requested due to automatic review settings October 8, 2026 12:09
@trissim
trissim merged commit 9775385 into main Oct 8, 2026
0 of 22 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim trissim changed the title Keep parent input responsive during optional child mounting Stop mounting children from blocking the parent's message queue Oct 11, 2026
@trissim
trissim deleted the fix/native-mount-completion-20261008 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants