Repository navigation
Stop mounting children from blocking the parent's message queue - #120
Merged
Merged
Conversation
Author
|
Integration review: the matched installed Toad App confirms the previous 219ms parent mount-completion callback hold is removed; history callbacks were about 1ms or less. Overall frame pacing still fails, so this is a targeted queue repair. Reviewed shared completion admission, distinct constructors, mount None result, cancellation and removal self-custody. The separate application viewport routing correction preserves native movement and nested controls. Proceeding with matched frontend integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mounting optional children queued a wait for composition on the parent's next-callback queue, which stopped wheel messages from bubbling through the parent while it waited.
await_complete.pynow has a sharedAwaitCompletionbase with acall_when_readymethod, andAwaitMountandAwaitRemoveuse it, so the parent gets its callback only after the mount has finished. Waiters can still await the mount, and cancelling one waiter does not cancel startup.app.pyandwidget.pyare updated to match, and tests are added totest_mount.py.