Skip to content

Keep cached measurements when only the pointer shape changes - #121

Merged
trissim merged 1 commit into
mainfrom
fix/native-pointer-style-geometry-20261008
Oct 8, 2026
Merged

trissim merged 1 commit into
mainfrom
fix/native-pointer-style-geometry-20261008

Conversation

@trissim

@trissim trissim commented Oct 8, 2026 •

Copy link
Copy Markdown

Changing the pointer style was treated like any unknown enum change, so it dropped cached content measurements and subtree geometry although it only changes the terminal pointer. StringEnumProperty in _style_properties.py now takes a geometry argument that defaults to true, and Styles.pointer in styles.py sets it to false. Other enum styles such as text wrapping, position and constrain keep their geometry effect. Tests are added to test_programmatic_style_changes.py.

Copilot AI balanced review requested due to automatic review settings October 8, 2026 12:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim

trissim commented Oct 8, 2026

Copy link
Copy Markdown
Author

Reviewed descriptor scope: pointer alone declares geometry=False; enum geometry remains conservative independently of scheduling layout. Native Content resources retain measurements, custom pointer-reading rendering remains sensitive, wrapping still invalidates. Source change is ready; current Parent channel-header delivery remains on its explicitly checked c330 cohort and does not claim this cursor fix is installed.

@trissim
trissim merged commit f1fa33d into main Oct 8, 2026
0 of 22 checks passed
@trissim trissim changed the title Keep native measurements when only the pointer shape changes Keep cached measurements when only the pointer shape changes Oct 11, 2026
@trissim
trissim deleted the fix/native-pointer-style-geometry-20261008 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants