Repository navigation
P21: render damaged rows once through the compositor owner - #139
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 17, 2026 00:20
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P21: one renderer, typed layout setters
Production source: +55/-107, net −52. Tests: +4/-4, four existing grid setups now use the stylesheet parser; no new tests and none run. No new module.
LayoutPropertystores the suppliedLayoutunchanged, with an identity no-op. Only the stylesheet parser callsget_layoutto decode external strings. Deleted the setter's decoder/name round-trip.layout.namecomparisons. CSS serialization still reads the declared name; it does not choose or replace a layout.Current-main ratchet exits0:
.artifacts/p21/typed-layout-final-ratchet.json. AST boundary/source evidence is retained in.artifacts/p21/and Toad'slayout-clock-before.json(880 production/dependency modules, zero parse omissions). Computed aliases are unresolved.Toad Textualize#696 needs this setter fix to retain
WorkspaceChromebehavior. Merge and install them together; #138 remains held/unpinned.Performance is not declared solved. The7e/eab source-candidate run measured59ms frame p95 and at most one layout start per paint, but exposed Toad geometry bugs. Those and P65 are repaired in Textualize#696; the fresh order requires P32 next and then one installed-build drag capture. Earlier failed series and raw failures are preserved in Toad's canonical performance table. No new source capture or A/B loop is planned.