Skip to content

P21: render damaged rows once through the compositor owner - #139

Merged
trissim merged 5 commits into
mainfrom
perf/compositor-render-walk
Oct 17, 2026
Merged

trissim merged 5 commits into
mainfrom
perf/compositor-render-walk

Conversation

@trissim

@trissim trissim commented Oct 16, 2026 •

Copy link
Copy Markdown

P21: one renderer, typed layout setters

Production source: +55/-107, net −52. Tests: +4/-4, four existing grid setups now use the stylesheet parser; no new tests and none run. No new module.

  • Deleted Screen's duplicate render-damage walk. Existing Compositor render/update methods own the deadline, atomic composition and one bound publication. Native synchronous callers use the existing step runner; no second renderer, timer or fallback cache.
  • Damage is consumed when output is consumed, not while binding it; Screen's batch/hold checks run before publication.
  • LayoutProperty stores the supplied Layout unchanged, with an identity no-op. Only the stylesheet parser calls get_layout to decode external strings. Deleted the setter's decoder/name round-trip.
  • Migrated every identified in-tree string setter: Toad's two goal-control setters use layout instances (Toad tests for auto refresh Textualize/textual#696); four Native test setups use CSS parsing. AST search found no layout.name comparisons. CSS serialization still reads the declared name; it does not choose or replace a layout.

Current-main ratchet exits0: .artifacts/p21/typed-layout-final-ratchet.json. AST boundary/source evidence is retained in .artifacts/p21/ and Toad's layout-clock-before.json (880 production/dependency modules, zero parse omissions). Computed aliases are unresolved.

Toad Textualize#696 needs this setter fix to retain WorkspaceChrome behavior. Merge and install them together; #138 remains held/unpinned.

Performance is not declared solved. The7e/eab source-candidate run measured59ms frame p95 and at most one layout start per paint, but exposed Toad geometry bugs. Those and P65 are repaired in Textualize#696; the fresh order requires P32 next and then one installed-build drag capture. Earlier failed series and raw failures are preserved in Toad's canonical performance table. No new source capture or A/B loop is planned.

@trissim
trissim marked this pull request as ready for review October 17, 2026 00:20
Copilot AI balanced review requested due to automatic review settings October 17, 2026 00:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim merged commit d290813 into main Oct 17, 2026
@trissim
trissim deleted the perf/compositor-render-walk branch October 17, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants